[#34996] - [4.0] Fix fatal error while uninstall deleted plugin
- Fixed in Code Base
- 2 Aug 2021
- Medium
- Build: 4.0-dev
- # 34996
- Diff
- joomdonation:fix_fatal_error_uninstall_plugin
User tests: Successful: Unsuccessful:
Pull Request for Issue #34992.
Summary of Changes
Currently, if we uninstall a plugin which was deleted for some reasons (or at least the manifest file was deleted), we will get fatal error because in the PluginAdater, we have code which didn't handle the case manifest not found.
This PR just adds some check to prevent these fatal error and allows these plugins still be uninstalled properly (mean the folder being deleted, the record is deleted from extensions table).
I think we can do it better. For example, in getElement, we can just return $this->extension->folder (it's plugin group) and in the code to detect plugin group, we can use $this->extension->folder, too, instead of getting these information from manifest object. But this is just handle some special case, so I think it is fine.
Testing Instructions
- Try to delete a plugin folder (or delete the xml file of that plugin)
- Uninstall that plugin
- Before patch: you will get fatal error
- After patch, the plugin will be uninstalled. Joomla also shows a warning to tell users that manifest not found.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
If complete folder is missing, a warning alert "Joomla\CMS\Filesystem\Folder::delete: Path is not a folder." is shown.
If only the manifest XML is missing, a warning alert "JInstaller: :Install: Can't find XML setup file." is shown.
In both cases the plugin has been properly uninstalled.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34996.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34996.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34996.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-02 09:31:02 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Fair enough. I'm down with that. Thankyou!
Grr, I had forgotten to select test result.