[#34995] - [3.10] Preupdate checker: Removing HTML from a name of a malformed extensions
- Fixed in Code Base
- 31 Jul 2021
- Medium
- Build: 3.10-dev
- # 34995
- Diff
- Fedik:clean-name
User tests: Successful: Unsuccessful:
Pull Request for Issue #34993 .
Summary of Changes
This removes any HTML that may be added by extension developers to the name translation.
Testing Instructions
Review should be enough.
But if you have such extension then please try test PreUpdate checker with it.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
After having restarted appveyor some 150 times it is ok now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34995.
With current 3.10-dev I could verify that this PR successfully strips off the image tag from an extensions name in the pre-update check. I have modified a patchtester 3.0.0 package for that. But I could not reproduce the broken pre-update checker described in issue #34993 . For me nothing crashed without the patch of this PR.
Maybe it has to be a critical plugin and not just any extensions which has to be used for reproducing the issue?
seems so, because it is used for nonCoreCriticalPlugin variable
seems so, because it is used for
nonCoreCriticalPluginvariable
Will eat something and later modify one of that type and check again.
I have tested this item
I've verified the issue and tested the patch with success. For this I've installed OSmap and modified the language string for the title of their system plugin so it contained an image tag.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34995.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34995.
Merging thanks.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-31 19:28:26 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Need to also check with language override created by site builder.
(waiting for joomla.org servers to be back online before I can test myself)