[#34971] - [4.0] Correctly handle multiple critical extensions within an package that is joomla 4 compatible
- Fixed in Code Base
- 30 Jul 2021
- Medium
- Build: 4.0-dev
- # 34971
- Diff
- richard67:4.0-dev-pre-update-js
User tests: Successful: Unsuccessful:
Pull Request for Issue #34968 .
Summary of Changes
Port PR #34776 to the 4.0-dev branch.
Testing Instructions
- Install latest akeeba, enable the system plugin (backup on update) and the action log plugin.
- Point your update server to the Joomla 4 nightlies (custom URL: https://update.joomla.org/core/nightlies/next_major_list.xml) in order to get the pre-update checker shown.
- Apply this PR
- Clear the browser / JS cache.
Actual result BEFORE applying this Pull Request
The pre upgrade checker shows a message about potentially not compatible plugins within that package.
Expected result AFTER applying this Pull Request
The pre update checker shows no message about that plugins cause they are compatible..
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
@richard67 you can filter the array:
if (extensionData.compatibilityData.resultGroup === 3) { PreUpdateChecker.nonCoreCriticalPlugins = PreUpdateChecker.nonCoreCriticalPlugins .filter((plugin) => plugin.package_id === extensionId || plugin.extension_id === extensionId); }
I should invert the condition, I think, because the old code removed elements from the array if matching that condition.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
Setting release blocker as inherited from the issue.
I should invert the condition, I think, because the old code removed elements from the array if matching that condition.
I think the original code suggested by @dgrammatiko is correct. Filter will remove element from array when condition match, so we should not invert the condition. Could you please check that?
@joomdonation Are you sure? https://www.javascripttutorial.net/javascript-array-filter/ https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Array/filter and so on ... either I understand them wrong or you are wrong.
@richard67 Sorry, my bad.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34971.
BEFORE
AFTER
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34971.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34971.
-
Point your update server to the Joomla 4 nightlies (custom URL: https://update.joomla.org/core/nightlies/next_major_list.xml) in order to get the pre-update checker shown.
-
In case if you are on a current 4.0-dev branch or latest nightly so your version is already
4.0-rc6-dev, edit filelibraries/src/Version.phpand changeconst EXTRA_VERSION = 'rc6-dev';toconst EXTRA_VERSION = 'rc6-dev';. Then reload the page and use again the button to check for updates, and then the pre-update check should be shown.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-30 07:18:49 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks all - testers, merger, and @dgrammatiko for the idea to use array.filter.
@richard67 you can filter the array: