? NPM Resource Changed

Pending

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
28 Jul 2021

Pull Request for Issue #34953 .

Summary of Changes

Changed field name siteDescription to siteTagline
Changed CSS c;lass site-description to site-tagline

Testing Instructions

Changing tagline of template style in back-end style editor will change the tagline in front-end.

Actual result BEFORE applying this Pull Request

The tagname changes on the front-end.

Expected result AFTER applying this Pull Request

The tagname changes on the front-end, as before.
CSS class site-tagline can be used to change the appearance of the tagline

Documentation Changes Required

avatar BrainforgeUK BrainforgeUK - open - 28 Jul 2021
avatar BrainforgeUK BrainforgeUK - change - 28 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2021
Category Front End Templates (site) NPM Change
avatar brianteeman
brianteeman - comment - 28 Jul 2021

I still do not understand the reason behind this change, its not for consistency so why? Please enlighten me. What am I missing.

avatar brianteeman
brianteeman - comment - 28 Jul 2021

Note that this PR is incomplete as there are sql changes that need to be made as well both for new installs and upgrades.

avatar BrainforgeUK
BrainforgeUK - comment - 28 Jul 2021

Consistency - change applies only within the Cassiopeia template.

SQL changes
(1) Cannot see any need for such on new installs.
(2) For production site upgrades would need and to change the field name in the params column of the template styles table. - as J4 is still at RC stage ...

avatar brianteeman
brianteeman - comment - 28 Jul 2021

Consistency with what?

as a clean install sets a param with the existing fieldname then of course it needs to be changed

avatar BrainforgeUK BrainforgeUK - change - 16 Aug 2021
Labels Added: ? NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2021
Category Front End Templates (site) NPM Change Libraries Front End Templates (site) NPM Change
avatar BrainforgeUK BrainforgeUK - change - 16 Aug 2021
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2021
Category Front End Templates (site) NPM Change Libraries Front End Templates (site) NPM Change
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2021
Category Front End Templates (site) NPM Change Libraries Front End Templates (site) NPM Change
avatar BrainforgeUK BrainforgeUK - change - 16 Aug 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-08-16 09:41:32
Closed_By BrainforgeUK
Labels Added: ?
Removed: ?
avatar BrainforgeUK BrainforgeUK - close - 16 Aug 2021
avatar BrainforgeUK
BrainforgeUK - comment - 16 Aug 2021

Reopened.

avatar BrainforgeUK BrainforgeUK - change - 16 Aug 2021
Status Closed New
Closed_Date 2021-08-16 09:41:32
Closed_By BrainforgeUK
avatar BrainforgeUK BrainforgeUK - change - 16 Aug 2021
Status New Pending
avatar BrainforgeUK BrainforgeUK - reopen - 16 Aug 2021

Add a Comment

Login with GitHub to post a comment