[#34957] - [4.0] Changed siteDescription field to siteTagline
- Closed
- 21 Oct 2022
- Medium
- Build: 4.0-dev
- # 34957
- Diff
- BrainforgeUK:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #34953 .
Summary of Changes
Changed field name siteDescription to siteTagline
Changed CSS c;lass site-description to site-tagline
Testing Instructions
Changing tagline of template style in back-end style editor will change the tagline in front-end.
Actual result BEFORE applying this Pull Request
The tagname changes on the front-end.
Expected result AFTER applying this Pull Request
The tagname changes on the front-end, as before.
CSS class site-tagline can be used to change the appearance of the tagline
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
Note that this PR is incomplete as there are sql changes that need to be made as well both for new installs and upgrades.
Consistency - change applies only within the Cassiopeia template.
SQL changes
(1) Cannot see any need for such on new installs.
(2) For production site upgrades would need and to change the field name in the params column of the template styles table. - as J4 is still at RC stage ...
Consistency with what?
as a clean install sets a param with the existing fieldname then of course it needs to be changed
| Labels |
Added:
?
NPM Resource Changed
|
||
| Category | Front End Templates (site) NPM Change | ⇒ | Libraries Front End Templates (site) NPM Change |
| Labels |
Added:
?
Removed: ? |
||
| Category | Front End Templates (site) NPM Change Libraries | ⇒ | Front End Templates (site) NPM Change |
| Category | Front End Templates (site) NPM Change | ⇒ | Libraries Front End Templates (site) NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-16 09:41:32 |
| Closed_By | ⇒ | BrainforgeUK | |
| Labels |
Added:
?
Removed: ? |
||
Reopened.
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-08-16 09:41:32 | ⇒ | |
| Closed_By | BrainforgeUK | ⇒ |
| Status | New | ⇒ | Pending |
@BrainforgeUK could you please resolve the conflicts?
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
Sorry that it took so long to make a decision, but we can't accept this PR, it implicates too many conflicts for existent websites using Cassiopeia and /or child templates.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-21 13:41:59 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
Conflicting Files
?
?
Removed: ? |
||
| Category | Front End Templates (site) NPM Change Libraries | ⇒ | Repository NPM Change Front End Templates (site) |
I still do not understand the reason behind this change, its not for consistency so why? Please enlighten me. What am I missing.