No Code Attached Yet
avatar brianteeman
brianteeman
26 Jul 2021

I was looking at the german language files and saw a big list of words in an array to be used by getIgnoredSearchWords and several other search related settings.

  • getIgnoredSearchWords
  • getLowerLimitSearchWord
  • getUpperLimitSearchWord
  • getSearchDisplayedCharactersNumber

The problem is that as far as I can tell they were only used by com_search and are not used by com_finder

For com_finder I believe the equivalent is

  • getIgnoredSearchWords is the list of words in com_finder.commonwords.txt
    and this is not enabled by default in the component options Filter Common Words

I dont see any equivalents for the other three

cc @HLeithner

UPDATE
I am guessing that these 4 settings will still be used by the code in the decoupled com_search which, for me, is a problem in that we have to maintain settings in core that are never used in core. If decoupled com_search needs these settings then they should be part of the component

avatar brianteeman brianteeman - open - 26 Jul 2021
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Jul 2021
avatar brianteeman brianteeman - change - 26 Jul 2021
The description was changed
avatar brianteeman brianteeman - edited - 26 Jul 2021
avatar brianteeman brianteeman - change - 26 Jul 2021
The description was changed
avatar brianteeman brianteeman - edited - 26 Jul 2021
avatar HLeithner
HLeithner - comment - 26 Jul 2021

I was looking at the german language files and saw a big list of words in an array to be used by getIgnoredSearchWords and several other search related settings.

  • getIgnoredSearchWords
  • getLowerLimitSearchWord
  • getUpperLimitSearchWord
  • getSearchDisplayedCharactersNumber

The problem is that as far as I can tell they were only used by com_search and are not used by com_finder

For com_finder I believe the equivalent is

  • getIgnoredSearchWords is the list of words in com_finder.commonwords.txt
    and this is not enabled by default in the component options Filter Common Words

I dont see any equivalents for the other three

I noticed this too and asked @Hackwar and he confirm this is not used in com_finder. The commonwords list can be edited in crowdin with a variable count of words.

UPDATE
I am guessing that these 4 settings will still be used by the code in the decoupled com_search which, for me, is a problem in that we have to maintain settings in core that are never used in core. If decoupled com_search needs these settings then they should be part of the component

I would say it's a bit late to change this and would keep then till the EOL of Joomla 4 and remove it in Joomla 5.0 if not used by any other component.

or did I missed anything @Hackwar ?

avatar brianteeman
brianteeman - comment - 26 Jul 2021

maybe added a deprecated note and/or a comment where it is used ?

avatar HLeithner
HLeithner - comment - 26 Jul 2021

the Problem is that it's defined in the language packs... but sure in the cms when we call the function we should create a note to it's deprecated.

avatar brianteeman brianteeman - change - 1 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-01 23:02:55
Closed_By brianteeman
Labels Added: No Code Attached Yet
Removed: ?
avatar brianteeman brianteeman - close - 1 Feb 2022

Add a Comment

Login with GitHub to post a comment