?
avatar Bond97
Bond97
26 Jul 2021

Maybe that error it's ok, but I want to create issue. Or it's not ok?

Steps to reproduce the issue

  1. Install clean 3.9.28
  2. Update to 3.10 alpha 9
  3. Set update url https://update.joomla.org/core/test/310to4_list.xml
  4. Update to Joomla 4 rc-4
  5. See error at the screenshot on "Actual result"

Expected result

Update process without any errors

Actual result

изображение

System information (as much as possible)

PHP 8.0.8, Mysql 5.7.34

avatar Bond97 Bond97 - open - 26 Jul 2021
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Jul 2021
avatar Bond97 Bond97 - change - 26 Jul 2021
The description was changed
avatar Bond97 Bond97 - edited - 26 Jul 2021
avatar Kostelano
Kostelano - comment - 26 Jul 2021

I was getting the same error when I upgraded from 3.9 to 3.10 to 4.0.

avatar richard67
richard67 - comment - 26 Jul 2021

It is well known that this is shown one time after the update and then disappears and doesn't come again when you start to navigate around in backend.

avatar Kostelano
Kostelano - comment - 26 Jul 2021

Everything is correct. However, I'm starting to curl my fingers how many more of these Issue will be created upon the release of the stable version 4.0.

avatar richard67
richard67 - comment - 26 Jul 2021

Yes, that would be a pain. I'm just clarifying if we have some docs about it or if we need some or need more.

avatar Bond97
Bond97 - comment - 26 Jul 2021

@richard67 maybe it will be better to show full description about this? When Joomla 4 goes to stable version, users will be ask questions about it.

For example, "The template Isis is not supported with Joomla 4 and now, after upgrade from Joomla 3.10, it was deleted"

avatar richard67
richard67 - comment - 26 Jul 2021

For example, "The template Isis is not supported with Joomla 4 and now, after upgrade from Joomla 3.10, it was deleted"

It's an error message shown in general when the template is not available. We don't have one for that special case of just having updated from 3.10 to 4.0. So if we just change the message text as suggested, the message will be wrong in other cases of missing templates.

avatar brianteeman
brianteeman - comment - 26 Jul 2021

So maybe we should look at changing that so it is a specific error with a specific message OR work to prevent that message appearing in the first place.

avatar brianteeman
brianteeman - comment - 26 Jul 2021

Looking at the code and considering what situation would trigger this message I would suggest not outputting a message at all by removing the following line or replacing it with a log message (ie not displayed on screen)

$this->enqueueMessage(Text::_('JERROR_ALERTNOTEMPLATE'), 'error');

The reality is that 99.99% of the time it will only be shown on updates and that is the one time that the message is incorrect and of no use.

avatar richard67
richard67 - comment - 26 Jul 2021

Looking at the code and considering what situation would trigger this message I would suggest not outputting a message at all by removing the following line or replacing it with a log message (ie not displayed on screen)

I'd be ok with that. Opinions from others are welcome.

avatar wilsonge
wilsonge - comment - 26 Jul 2021

I'd be happy with a log message too. I think it's fairly consistent with things as it's not something that an end user can fix anyhow if they saw it in the frontend too.

avatar brianteeman
brianteeman - comment - 26 Jul 2021

this would only be in the admin but I will prepare a PR

avatar richard67 richard67 - close - 26 Jul 2021
avatar richard67
richard67 - comment - 26 Jul 2021

Closing as having a pull request. Please test #34912 (and if necessary continue discussion there). Thanks in advance.

avatar richard67 richard67 - change - 26 Jul 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-07-26 11:26:16
Closed_By richard67
avatar richard67 richard67 - change - 26 Jul 2021
Status Closed New
Closed_Date 2021-07-26 11:26:16
Closed_By richard67
avatar richard67 richard67 - reopen - 26 Jul 2021
avatar richard67
richard67 - comment - 26 Jul 2021

Re-opening since the pull request has been closed.

avatar Fedik
Fedik - comment - 26 Jul 2021

I have made another one #34914 , please review first, maybe it also not good

avatar Fedik
Fedik - comment - 27 Jul 2021

Because we cannot use jerror for log there, and seems we do not have another appretiere category, so instead of introducing new category (that will be only here and no one will know about it) I suggest to remove that line.

A couple lines down there an exception if something crazy happen:

$this->enqueueMessage(Text::_('JERROR_ALERTNOTEMPLATE'), 'error');
$template->params = new Registry;
$template->template = 'atum';
// Check, the data were found and if template really exists
if (!is_file(JPATH_THEMES . '/' . $template->template . '/index.php'))
{
throw new \InvalidArgumentException(Text::sprintf('JERROR_COULD_NOT_FIND_TEMPLATE', $template->template));
}

avatar brianteeman
brianteeman - comment - 27 Jul 2021

agree

avatar Fedik
Fedik - comment - 27 Jul 2021

another one #34930 please check :)

avatar richard67
richard67 - comment - 27 Jul 2021

Closing as having a pull request. Please test #34930 . Thanks in advance.

avatar richard67 richard67 - change - 27 Jul 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-07-27 15:28:51
Closed_By richard67
avatar richard67 richard67 - close - 27 Jul 2021

Add a Comment

Login with GitHub to post a comment