PR-4.3-dev ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
25 Jul 2021

Pull Request for Issue # .

Summary of Changes

The $params variable returned from $app->getParams(); already contains component parameters merged with active menu item parameters, so no need to merge it with active menu item parameters again.

For reference, we do it right in Categories model https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/src/Model/CategoriesModel.php#L69-L70

Testing Instructions

Code review only.

avatar joomdonation joomdonation - open - 25 Jul 2021
avatar joomdonation joomdonation - change - 25 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2021
Category Front End com_content
avatar joomdonation joomdonation - change - 25 Jul 2021
Title
Simplify com_content params model state
[4.0] Simplify com_content params model state
avatar joomdonation joomdonation - edited - 25 Jul 2021
avatar chmst chmst - change - 31 Jan 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar rdeutz rdeutz - change - 21 Oct 2022
Title
[4.0] Simplify com_content params model state
Simplify com_content params model state
avatar rdeutz rdeutz - edited - 21 Oct 2022
avatar rdeutz rdeutz - change - 21 Oct 2022
Labels Added: ? PR-4.3-dev ?
Removed: ?
avatar bembelimen bembelimen - change - 21 Oct 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-21 16:10:39
Closed_By bembelimen
Labels Removed: ?
avatar bembelimen bembelimen - close - 21 Oct 2022
avatar bembelimen bembelimen - merge - 21 Oct 2022
avatar bembelimen
bembelimen - comment - 21 Oct 2022

Thx

Add a Comment

Login with GitHub to post a comment