Feeling Lucky
?
[#34891] - [4.0] Improve $app->getParams logic
- Closed
- 20 Jun 2022
- Medium
- Build: 4.0-dev
- # 34891
- Diff
- joomdonation:app_getparams
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The getParams method in SiteApplication class https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Application/SiteApplication.php#L284 return component parameters after merging it with active menu item parameters (the menu item parameters take higher priority). However, it does not check and make sure the menu item is linked to current component before merging, and this PR just adds that missing check.
Testing Instructions
This need code review from developers understand how parameters is handle in Joomla!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-20 03:10:52 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
Removed: ? |
||
The improvement is okay but it doesn't decrease the code length.
