NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
22 Jul 2021

Pull Request for Issue #34843 .

Summary of Changes

Fixes the menu hover in RTL

Testing Instructions

Swap en-GB to RTL mode. Close the menu (see the screenshot in the issue) and hover over the menu items. Before patch no items fly out. After patch they do.

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 22 Jul 2021
avatar wilsonge wilsonge - change - 22 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2021
Category Administration Templates (admin) NPM Change
avatar wilsonge wilsonge - change - 22 Jul 2021
Labels Added: NPM Resource Changed ?
avatar brianteeman brianteeman - test_item - 22 Jul 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Jul 2021

I have tested this item successfully on bcbe7c9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34869.

avatar ChristineWk ChristineWk - test_item - 22 Jul 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

I have tested this item successfully on bcbe7c9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34869.

avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

Result:
screen shot 2021-07-22 at 17 39 59


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34869.

avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

It's OT, but hv a question. When I go back from Prebuilt Package (to install Nightly again):

screen shot 2021-07-22 at 17 53 39

missing space there?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34869.

avatar Quy Quy - change - 22 Jul 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34869.

avatar wilsonge
wilsonge - comment - 22 Jul 2021

It's OT, but hv a question. When I go back from Prebuilt Package (to install Nightly again):

I'll put in another PR for that one. Good spot!

avatar wilsonge wilsonge - change - 22 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-22 22:41:11
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 22 Jul 2021
avatar wilsonge wilsonge - merge - 22 Jul 2021
avatar wilsonge
wilsonge - comment - 22 Jul 2021

Add a Comment

Login with GitHub to post a comment