? ?
avatar alisha-kamat
alisha-kamat
22 Jul 2021

Pull Request for Issue #34798 .

Summary of Changes

User session shouldn't get destroyed if not changing password/blocking user.

avatar alisha-kamat alisha-kamat - open - 22 Jul 2021
avatar HLeithner
HLeithner - comment - 23 Jul 2021

This looks like a working solution maybe some input from @joomla/security ?

avatar SniperSister
SniperSister - comment - 24 Jul 2021

Looks good to me, thanks @Quy !

avatar richard67
richard67 - comment - 24 Jul 2021

Looks good to me, thanks @Quy !

@SniperSister But he's not the author here.

avatar richard67
richard67 - comment - 24 Jul 2021

We have a problem in the issue tracker with this PR (not this PR's fault though), so we don't have the "Test this" button there to mark test results by human testers.

avatar richard67 richard67 - change - 24 Jul 2021
Status New Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 24 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34868.

avatar joomdonation
joomdonation - comment - 24 Jul 2021

I tested and it worked. So count my test as one successful test.

avatar richard67
richard67 - comment - 24 Jul 2021

I tested and it worked. So count my test as one successful test.

This plus the two approvals are ok for me to set RTC.

avatar richard67 richard67 - close - 24 Jul 2021
avatar richard67 richard67 - merge - 24 Jul 2021
avatar richard67 richard67 - change - 24 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-24 14:56:52
Closed_By richard67
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2021
Category Administration com_users
avatar richard67
richard67 - comment - 24 Jul 2021

@alisha-kamat Thank you very much for your first pull request to this repository. Of course we'd be happy if you find the time to contribute again in future. Report issues, make pull requests, test other pull requests ... any activity is welcome.

avatar alisha-kamat
alisha-kamat - comment - 26 Jul 2021

@richard67 The issue wasn't too complicated, but since this was my first pull request, understanding the entire process was a little tricky for me. Having gone through the learning curve will make the subsequent one a little easier to solve hopefully. Thank you for your support and encouragement.

Add a Comment

Login with GitHub to post a comment