User tests: Successful: Unsuccessful:
Pull Request for Issue #34855.
This PR fixes re-order nested items (categories/menu items) as described in #34855. I did two things here:
drop
instead of dragend
. I haven't had time to check to see why it is not working for dragend
but we always use drop
before and it works, so it makes sense to make the changeStatus | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
Thanks @richard67. Should be fixed now.
@joomdonation The scss code style error has just been fixed in the 4.0-dev branch, so if you update the branch your PR it will be ok here, too.
Setting release blocker label as inherited from the issue.
Prebuilt Package.
OK: categories and menues
articles and modules inactive icon:
Therefore: Not sure about
@ChristineWk Thanks for testing. You need to click on the order icon to have items ordered by ordering before you can change order. See this attached screenshot
Thank you - I saw it minutes before and it's OK now :-)Because the 1st column belongs to "actions".
So: categories, menues and articles = successful.
modules: No. Can't reorder
@ChristineWk Note that you can only change order of modules from same position. So if the two modules are from different positions , you cannot change ordering
Same with articles from different categories
Ahhhhh, of course: Same positions, sounds logical now. I hadn't noticed. And it works :-)
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-22 17:27:42 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
?
|
SCSS code style errors in Drone are not related to this PR but to the 4.0-dev branch currently have such an error.
@joomdonation But the javascript code style error in Drone is related to this PR, see https://ci.joomla.org/joomla/joomla-cms/45993/1/21 :