NPM Resource Changed ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 Jul 2021

Pull Request for Issue #34855.

Summary of Changes

This PR fixes re-order nested items (categories/menu items) as described in #34855. I did two things here:

  • Move the code to save order back to drop instead of dragend. I haven't had time to check to see why it is not working for dragend but we always use drop before and it works, so it makes sense to make the change
  • Remove the code to initialize data-order for each item and reset it on dragend. We do not use data-order in our script at the moment, so no need to set data for it.

Testing Instructions

  1. Confirm the issue #34855
  2. Update your site to update package for this PR
  3. Try to change ordering of categories and make sure it is working as expected. It would be good if you can test change ordering of menu items, modules, articles and make sure it is still working, too.
avatar joomdonation joomdonation - open - 22 Jul 2021
avatar joomdonation joomdonation - change - 22 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2021
Category JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 22 Jul 2021

SCSS code style errors in Drone are not related to this PR but to the 4.0-dev branch currently have such an error.

@joomdonation But the javascript code style error in Drone is related to this PR, see https://ci.joomla.org/joomla/joomla-cms/45993/1/21 :

/********/src/build/media_source/system/js/draggable.es6.js
11:5  error  'dropElement' is defined but never used         no-unused-vars
13:7  error  'orderRows' is assigned a value but never used  no-unused-vars

2 problems (2 errors, 0 warnings)
d7ba0b5 22 Jul 2021 avatar joomdonation CS
avatar joomdonation joomdonation - change - 22 Jul 2021
Labels Added: NPM Resource Changed ?
avatar joomdonation
joomdonation - comment - 22 Jul 2021

Thanks @richard67. Should be fixed now.

avatar richard67
richard67 - comment - 22 Jul 2021

@joomdonation The scss code style error has just been fixed in the 4.0-dev branch, so if you update the branch your PR it will be ok here, too.

avatar richard67
richard67 - comment - 22 Jul 2021

Setting release blocker label as inherited from the issue.

avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

Prebuilt Package.

OK: categories and menues

articles and modules inactive icon:screen shot 2021-07-22 at 09 48 09
Therefore: Not sure about


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34864.

avatar joomdonation
joomdonation - comment - 22 Jul 2021

@ChristineWk Thanks for testing. You need to click on the order icon to have items ordered by ordering before you can change order. See this attached screenshot
Articles-Joomla-4-RC5-Administration

avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

@joomdonation

Thank you - I saw it minutes before and it's OK now :-)Because the 1st column belongs to "actions".

So: categories, menues and articles = successful.
modules: No. Can't reorder


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34864.

avatar joomdonation
joomdonation - comment - 22 Jul 2021

@ChristineWk Note that you can only change order of modules from same position. So if the two modules are from different positions , you cannot change ordering

Same with articles from different categories

avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

@joomdonation

Ahhhhh, of course: Same positions, sounds logical now. I hadn't noticed. And it works :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34864.

avatar ChristineWk ChristineWk - test_item - 22 Jul 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 22 Jul 2021

I have tested this item successfully on b239457


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34864.

avatar chmst chmst - test_item - 22 Jul 2021 - Tested successfully
avatar chmst
chmst - comment - 22 Jul 2021

I have tested this item successfully on b239457


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34864.

avatar richard67 richard67 - change - 22 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34864.

avatar rdeutz rdeutz - change - 22 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-22 17:27:42
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 22 Jul 2021
avatar rdeutz rdeutz - merge - 22 Jul 2021

Add a Comment

Login with GitHub to post a comment