? ? Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
18 Jul 2021

Summary of Changes

Using the switcher field it is now impossible to specify any classes on the input element even though the field element is passed to the layout. In the layout this value is just ignored.

Testing Instructions

  1. Open the file /administrator/components/com_config/forms/application.xml
  2. Go to line 297
  3. After this line add class="test"
  4. Save the file
  5. Go to <URL>/administrator/index.php?option=com_config
  6. Click on the System tab
  7. Inspect the Debug System switcher
  8. Notice that the class is not set on the input elements
  9. Apply patch
  10. Reload the page
  11. Inspect the Debug System switcher
  12. Notice that the test class is set on the input elements

Actual result BEFORE applying this Pull Request

There is no class set on the input element

Expected result AFTER applying this Pull Request

The specified class is set on the input element

Documentation Changes Required

None

avatar roland-d roland-d - open - 18 Jul 2021
avatar roland-d roland-d - change - 18 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2021
Category Layout
avatar YatharthVyas YatharthVyas - test_item - 19 Jul 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 19 Jul 2021

I have tested this item successfully on f278914

Before Patch After Patch
before after
Class is not applied Class .test is applied

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34826.
avatar hans2103 hans2103 - test_item - 19 Jul 2021 - Tested successfully
avatar hans2103
hans2103 - comment - 19 Jul 2021

I have tested this item successfully on f278914


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34826.

avatar richard67 richard67 - change - 19 Jul 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 19 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34826.

avatar Quy Quy - close - 19 Jul 2021
avatar Quy Quy - merge - 19 Jul 2021
avatar Quy Quy - change - 19 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-19 15:42:47
Closed_By Quy
Labels Added: ?
avatar Quy
Quy - comment - 19 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment