? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Jul 2021

This css class was removed in bootstrap 5 and we are not using the markup anywhere in the core so it makes no sense to keep it and keep maintaining css that isnt used.

To test I guess code review, make sure the scss still compiles and confirm that the classes are not being used.

NOTE: it is still used in plg_installer_webinstaller and that will be addressed in a sperate pr as it also requires upstream changes

avatar brianteeman brianteeman - open - 18 Jul 2021
avatar brianteeman brianteeman - change - 18 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2021
Category Administration Templates (admin) NPM Change Front End Templates (site)
avatar Quy Quy - test_item - 18 Jul 2021 - Tested successfully
avatar Quy
Quy - comment - 18 Jul 2021

I have tested this item successfully on 3f30494


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34825.

avatar RickR2H RickR2H - test_item - 20 Jul 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 20 Jul 2021

I have tested this item successfully on 3f30494


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34825.

avatar Quy Quy - change - 20 Jul 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 20 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34825.

avatar wilsonge wilsonge - change - 21 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-21 21:52:56
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Jul 2021
avatar wilsonge wilsonge - merge - 21 Jul 2021
avatar wilsonge
wilsonge - comment - 21 Jul 2021

Thanks!

avatar brianteeman
brianteeman - comment - 21 Jul 2021

thanks

Add a Comment

Login with GitHub to post a comment