Feeling Lucky
?
?
[#34806] - [4.0] Fix wrong parameter type for language in prepared statement
- Fixed in Code Base
- 18 Jul 2021
- Medium
- Build: 4.0-dev
- # 34806
- Diff
- joomdonation:fix_parameter_type
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR corrects parameter type for prepared statement for language in query. We need to use ParameterType::STRING (instead of using ParameterType::INTEGER by default which would result in wrong data returned). For reference, we have correct code in com_content https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/src/Model/ArticlesModel.php#L637
Testing Instructions
Code review should be enough.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners com_contact com_newsfeeds |
alikon
- comment
- 18 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34806.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
alikon
- comment
- 18 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34806.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-18 06:04:42 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 18 Jul 2021
Thanks
I have tested this item✅ successfully on f9624be
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34806.