NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
16 Jul 2021

Pull Request for Issue #34793. Revert #34426.

Summary of Changes

Fix toolbar scrolls out of view.

Testing Instructions

Download/install the prebuilt package.
or
Apply PR.
Run npm run build:css

Go to Global Configuration.
Scroll down.

Actual result BEFORE applying this Pull Request

Toolbar scrolls out of view.

Expected result AFTER applying this Pull Request

Toolbar sticks at the top.

avatar Quy Quy - open - 16 Jul 2021
avatar Quy Quy - change - 16 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2021
Category Administration Templates (admin) NPM Change
avatar Quy Quy - change - 16 Jul 2021
The description was changed
avatar Quy Quy - edited - 16 Jul 2021
avatar Quy Quy - change - 16 Jul 2021
The description was changed
avatar Quy Quy - edited - 16 Jul 2021
avatar chmst chmst - test_item - 17 Jul 2021 - Tested successfully
avatar chmst
chmst - comment - 17 Jul 2021

I have tested this item successfully on 2d4679a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34805.

avatar brianteeman
brianteeman - comment - 17 Jul 2021

I'm assuming that while this fixes the sticky it reintroduces the overflow issue?

avatar Quy
Quy - comment - 17 Jul 2021

This restores the functionality that #34426 inadvertently broke to fix #32820.

avatar richard67
richard67 - comment - 17 Jul 2021

Issue #32820 is still open so nothing got lost.

avatar brianteeman
brianteeman - comment - 18 Jul 2021

Thanks for answering the question @richard67

avatar brianteeman brianteeman - test_item - 18 Jul 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Jul 2021

I have tested this item successfully on 2d4679a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34805.

avatar richard67 richard67 - change - 18 Jul 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 18 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34805.

avatar Quy Quy - close - 19 Jul 2021
avatar Quy Quy - merge - 19 Jul 2021
avatar Quy Quy - change - 19 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-19 20:20:40
Closed_By Quy
Labels Added: ?
avatar Quy
Quy - comment - 19 Jul 2021

Also fixed #34842.

Add a Comment

Login with GitHub to post a comment