[#34795] - [4.0] Finder Indexer does not work when debug is enabled
- Fixed in Code Base
- 15 Jul 2021
- Medium
- Build: 4.0-dev
- # 34795
- Diff
- wilsonge:fix/debug-finder
User tests: Successful: Unsuccessful:
Pull Request for Issue #34665 .
Summary of Changes
Fixes finder when debug mode is enabled - due to the default JS filter not allowing <dd> tags by default. @dgrammatiko tagging you in case you have a better fix - as it's from the sanitiseHtml stuff - but I think this is fine.
Testing Instructions
Go to the Joomla Configuration > System and enable the "System Debug".
Go to components Smart Search and click the "Clear Index" button.
Go to components Smart Search and click the "Index" button.
Actual result BEFORE applying this Pull Request
Finder loads the modal but never progresses to show a progress bar
Expected result AFTER applying this Pull Request
Finder index's all content as expected
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
Works like a charm.
Hint for other testers: You have to use npm run build:js to rebuild the js (or npm ci), or use the package built by drone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34795.
I have tested this item
With Prebuilt Package
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34795.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34795.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-15 14:30:24 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks!
This is fine as is. Another approach is to add
ddanddlin the allowedElements in core.js but I prefer your solution here