User tests: Successful: Unsuccessful:
Pull Request for #34754 (comment) .
Move the files which have been removed in RC 4 with PR #34754 to the right section of the deleted files list in script.php.
They have been added to section "From 3.10 to 4.0" of the $files array by PR #34754 due to my advise.
But I was missing the fact that these templates were at a different place in J3, and these J3 files are already deleted on update, so the deletion of the J4 files due to PR #34754 belongs to section "4.0 from RC 3 to RC 4".
This PR here fixes my mistake so the deleted files list in script.php is consistent with what the tool (build/deleted_file_check.php) creates when being used in the right way.
Code review.
Files which have been removed in 4.0 RC 4 due to PR #34754 are located in the "// From 3.10 to 4.0" section of the $files array.
Files which have been removed in 4.0 RC 4 due to PR #34754 are located in the "// 4.0 from RC 3 to RC 4" section of the $files array.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-14 21:15:57 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!