? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
14 Jul 2021

Pull Request for #34754 (comment) .

Summary of Changes

Move the files which have been removed in RC 4 with PR #34754 to the right section of the deleted files list in script.php.

They have been added to section "From 3.10 to 4.0" of the $files array by PR #34754 due to my advise.

But I was missing the fact that these templates were at a different place in J3, and these J3 files are already deleted on update, so the deletion of the J4 files due to PR #34754 belongs to section "4.0 from RC 3 to RC 4".

This PR here fixes my mistake so the deleted files list in script.php is consistent with what the tool (build/deleted_file_check.php) creates when being used in the right way.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Files which have been removed in 4.0 RC 4 due to PR #34754 are located in the "// From 3.10 to 4.0" section of the $files array.

Expected result AFTER applying this Pull Request

Files which have been removed in 4.0 RC 4 due to PR #34754 are located in the "// 4.0 from RC 3 to RC 4" section of the $files array.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 14 Jul 2021
avatar richard67 richard67 - change - 14 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2021
Category Administration com_admin
avatar wilsonge wilsonge - change - 14 Jul 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-14 21:15:57
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Jul 2021
avatar wilsonge wilsonge - merge - 14 Jul 2021
avatar wilsonge
wilsonge - comment - 14 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment