? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
14 Jul 2021

Pull Request for Issue joomla-backports/PHPMailer#5

Summary of Changes

Backported the fixes for CVE-2021-34551 and CVE-2021-3603

Testing Instructions

Make sure the phpmailer still works

Actual result BEFORE applying this Pull Request

CVE-2020-34551 and CVE-2021-3603

Expected result AFTER applying this Pull Request

CVE-2020-34551 and CVE-2021-3603 patched

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 14 Jul 2021
avatar zero-24 zero-24 - change - 14 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2021
Category External Library Composer Change Libraries
avatar richard67
richard67 - comment - 14 Jul 2021

@zero-24 Unit tests are failing for PHP 5.3, see e.g. https://ci.joomla.org/joomla/joomla-cms/45817/2/8 :

PHP Parse error:  syntax error, unexpected '[' in /drone/src/libraries/vendor/phpmailer/phpmailer/class.phpmailer.php on line 1826

Can it be that the backport uses short array syntax which is not supported in these old PHP versions?

avatar zero-24 zero-24 - change - 14 Jul 2021
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 14 Jul 2021

That should fix it if so i'm doing an upstream PR and update here too.

avatar zero-24
zero-24 - comment - 14 Jul 2021

Drone is happy now will update it on the repo and update here: https://ci.joomla.org/joomla/joomla-cms/45819/2/8

avatar zero-24
zero-24 - comment - 14 Jul 2021

Branch updated with the latest changes from the backports repo.

avatar richard67 richard67 - test_item - 18 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 18 Jul 2021

I have tested this item successfully on 1a78cd5

I've successfully tested this PR with both methods "PHP Mail" and "SMTP".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34783.

avatar ChristineWk ChristineWk - test_item - 18 Jul 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 Jul 2021

I have tested this item successfully on 1a78cd5

tested with method "PHP Mail"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34783.

avatar richard67 richard67 - change - 18 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 18 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34783.

avatar zero-24
zero-24 - comment - 25 Jul 2021

Merging for now thanks!

avatar zero-24 zero-24 - change - 25 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-25 08:42:16
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 25 Jul 2021
avatar zero-24 zero-24 - merge - 25 Jul 2021

Add a Comment

Login with GitHub to post a comment