Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34778] - [4.0] Add fallback for the new media setting and fix some phpcs

? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
14 Jul 2021

Pull Request for Issue #34634

Summary of Changes

Add fallback for the new media setting and fix some phpcs

Testing Instructions

Install 3.10-alpha9
Upgrade to the latest 4.0
Notice that you can not upload images in the media manager
Install a new 3.10-alpha9
Update using this update server (https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/34778/downloads/45806/pr_list.xml)
Notice that the upload works

Actual result BEFORE applying this Pull Request

Media Manager Upload works

Expected result AFTER applying this Pull Request

Media Manager upload does not work when the option is not set yet.

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 14 Jul 2021
avatar particthistle particthistle - test_item - 14 Jul 2021 - Tested successfully
avatar particthistle
particthistle - comment - 14 Jul 2021

I have tested this item ✅ successfully on 733728b

Before: 4.0.0-rc5-dev (13/7/2021) was unable to upload images.

After: 4.0.0-rc5-dev+pr.34778 - able to upload images to media manager.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34778.

avatar zero-24 zero-24 - change - 14 Jul 2021
The description was changed
avatar zero-24 zero-24 - edited - 14 Jul 2021
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2021
Category ⇒ Libraries Front End Plugins
avatar zero-24 zero-24 - change - 14 Jul 2021
The description was changed
avatar zero-24 zero-24 - edited - 14 Jul 2021
avatar richard67 richard67 - test_item - 14 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 14 Jul 2021

I have tested this item ✅ successfully on 733728b

Easier test:

  1. Update a current 3.10-dev or latest 3.10 nightly or 3.10-alpha9 to the latest 4.0 nightly build.
  2. Try to upload a png file in media manager => fails.
  3. Update now to the custom update URL built by Drone for this PR.
  4. Try to upload a png file in media manager => works.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34778.
avatar richard67 richard67 - change - 14 Jul 2021
Status New ⇒ Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 14 Jul 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34778.

avatar Quy Quy - change - 14 Jul 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-07-14 16:59:06
Closed_By ⇒ Quy
Labels Added: ?
avatar Quy Quy - close - 14 Jul 2021
avatar Quy Quy - merge - 14 Jul 2021
avatar Quy
Quy - comment - 14 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment