Feeling Lucky
?
?
[#34777] - Fix indentation in module container in top and bottom positions
- Fixed in Code Base
- 21 Jul 2021
- Medium
- Build: 4.0-dev
- # 34777
- Diff
- RickR2H:Fix-Cassiopeia-module-margins
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The modules in Top-a, Top-b, Bottom-a, and Bottom-b all use margins to create spacing between the modules. This creates a indentation on the left and the right site of the module container. This PR removes the side margins and add the gutter the same like the Left and Right positions.
Testing Instructions
Add multiple modules to the Top and Bottom positions and see if the indentation is there. Apply the PR an rebuild the CSS.
Actual result BEFORE applying this Pull Request
Indentation on the left and right site of the module position.
Expected result AFTER applying this Pull Request
The indentation is removed.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
sandewt
- comment
- 14 Jul 2021
Results after testing: OK
ricardo1709
- comment
- 14 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34777.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 14 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34777.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-21 21:53:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 21 Jul 2021
Thanks!
I have tested this item✅ successfully on 6141952
See comment
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34777.