Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
18 Apr 2014
avatar phproberto phproberto - open - 18 Apr 2014
avatar phproberto
phproberto - comment - 18 Apr 2014

I squashed all my commits and rebased.

Ready to merge here

avatar phproberto phproberto - change - 18 Apr 2014
Title
Ie8 george
IE8 fixes for validation, search tools, etc.
avatar phproberto phproberto - change - 18 Apr 2014
Title
IE8 fixes for validation, search tools, etc.
IE8 fixes for validation, searchtools, etc.
avatar wilsonge
wilsonge - comment - 18 Apr 2014

Looks good to me. I'll test tomorrow morning

avatar zero-24
zero-24 - comment - 18 Apr 2014

@phproberto @wilsonge I tested here successfull on a "real" IE8. (setup: 3.3.beta2 + this patch with com_patchtester)
E.g. the searchtools and save buttons (save, save&close, save&new) working now also for IE8 e.g. at the article view :+1:

Is there somthing more that can/must be tested?
Thanks

avatar wilsonge
wilsonge - comment - 18 Apr 2014

Can you test installing Joomla itself with IE8 please? But thankyou!!

avatar wilsonge
wilsonge - comment - 18 Apr 2014

@phproberto can we push a similar thing to staging please? Just without the validate stuff obviously. That way we can get this fix into the 3.2 branch

avatar zero-24
zero-24 - comment - 18 Apr 2014

@phproberto @wilsonge
Installation with IE8 still hangs at step one.
I can fill out the boxes but after the click to "Next" the installer run (blue bars) and then jump back to the first step.
Same Installation Files works with current FF.

It looks like that the validation fails.
e.g. if i don't repeat the Admin PW the box is red but no message will show there.

avatar phproberto phproberto - change - 19 Apr 2014
Title
Ie8 george
IE8 fixes for validation, searchtools, etc.
Labels Added: ? ?
avatar phproberto
phproberto - comment - 19 Apr 2014

@wilsonge I'll do it as soon as we have all the errors covered to avoid duplicate coding/testing

@zero-24 I just tested the installer and everything works fine here. Can you recheck it and try to send me more information about the error?

avatar Bakual
Bakual - comment - 19 Apr 2014

I can confirm that validation works again with this PR in IE8.
The language override function is fixed as well. :+1:
Also the installation works now (and was indeed broken before).

Thanks a lot for this effort! Awesome stuff!

avatar mbabker
mbabker - comment - 19 Apr 2014

Tested well for me too. I think we're good.

avatar mbabker mbabker - reference | - 19 Apr 14
avatar mbabker mbabker - merge - 19 Apr 2014
avatar mbabker mbabker - close - 19 Apr 2014
avatar mbabker mbabker - change - 19 Apr 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-04-19 19:40:11
avatar mbabker mbabker - close - 19 Apr 2014
avatar phproberto phproberto - head_ref_deleted - 19 Apr 2014
avatar wilsonge
wilsonge - comment - 19 Apr 2014

Thanks so much for putting your time into this @mbabker and @phproberto :)

avatar phproberto
phproberto - comment - 20 Apr 2014

Thanks to you @wilsonge for taking the lead to start working on it

avatar betweenbrain
betweenbrain - comment - 20 Apr 2014

Thanks all, ya'll rock!

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Apr 19, 2014 8:24 PM, "Roberto Segura" notifications@github.com wrote:

Thanks to you @wilsonge https://github.com/wilsonge for taking the lead
to start working on it


Reply to this email directly or view it on GitHub#3474 (comment)
.

avatar Bakual Bakual - reference | b81b0b7 - 12 May 14

Add a Comment

Login with GitHub to post a comment