User tests: Successful: Unsuccessful:
Title |
|
Title |
|
Looks good to me. I'll test tomorrow morning
@phproberto @wilsonge I tested here successfull on a "real" IE8. (setup: 3.3.beta2 + this patch with com_patchtester)
E.g. the searchtools and save buttons (save, save&close, save&new) working now also for IE8 e.g. at the article view
Is there somthing more that can/must be tested?
Thanks
Can you test installing Joomla itself with IE8 please? But thankyou!!
@phproberto can we push a similar thing to staging please? Just without the validate stuff obviously. That way we can get this fix into the 3.2 branch
@phproberto @wilsonge
Installation with IE8 still hangs at step one.
I can fill out the boxes but after the click to "Next" the installer run (blue bars) and then jump back to the first step.
Same Installation Files works with current FF.
It looks like that the validation fails.
e.g. if i don't repeat the Admin PW the box is red but no message will show there.
Title |
|
||||||
Labels |
Added:
?
?
|
I can confirm that validation works again with this PR in IE8.
The language override function is fixed as well.
Also the installation works now (and was indeed broken before).
Thanks a lot for this effort! Awesome stuff!
Tested well for me too. I think we're good.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-19 19:40:11 |
Thanks so much for putting your time into this @mbabker and @phproberto :)
Thanks all, ya'll rock!
Best,
Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain
Sent from mobile. Please pardon any typos or brevity.
On Apr 19, 2014 8:24 PM, "Roberto Segura" notifications@github.com wrote:
Thanks to you @wilsonge https://github.com/wilsonge for taking the lead
to start working on it—
Reply to this email directly or view it on GitHub#3474 (comment)
.
I squashed all my commits and rebased.
Ready to merge here