? Success

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
17 Apr 2014

Bugfix of the described problem here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33602&start=0

Most important thing is the introduction of the new attribute "show_cat_tags" to distinct between the tags for articles and categories. The output and control of the tags for the different layouts (featured, blog, article) was also improved.

How to test?

Create some articles and categories with tags. Also create menu entries for the described layout views. Now play around with the different setting possibilities -> Enable and disable the option "Show Tags" for articles and categories in

  • menu entries
  • global settings
  • article

Plus in the pull request: many code styling improvements

avatar Kubik-Rubik Kubik-Rubik - open - 17 Apr 2014
avatar Kubik-Rubik Kubik-Rubik - change - 17 Apr 2014
Title
Tags in com_content - Distinction between article and category tags
[#33602] Tags in com_content - Distinction between article and category tags
avatar zero-24
zero-24 - comment - 18 Apr 2014

@Kubik-Rubik
I can't find the "Show Tags" option at the category options (BE -> Content --> Category Manager --> "Category name" --> Options)
Or is this expected?

At the others i can't see a issue with tags display, all works as expected here. (setup: 3.3beta2 + this patch with com_patchtester)

avatar ch2856
ch2856 - comment - 18 Apr 2014

Kubik, Thanks for the add
I am not a developer so I have no idea even how to test the patch.
Don't know if it will be fixed on j3.3 SR, but there are no options at all for tags display on:
menu - category blog or Featured Articles

avatar zero-24
zero-24 - comment - 18 Apr 2014

@ch2856
You can test this at first by applying the patch e.g. with the com_patchtester component:
Documentation: http://docs.joomla.org/Component_Patchtester_for_Testers
Download: https://github.com/mbabker/patchtester/releases

After you apply the patch you can follow the test instructions by @Kubik-Rubik above.

How to test?

Create some articles and categories with tags. Also create menu entries for the described layout views. Now play around with the different setting possibilities -> Enable and disable the option "Show Tags" for articles and categories in

menu entries
global settings
article
avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Apr 2014

@zero-24 This is correct. You can set the global value in the settings of the content component, not in each single category entry. We can think about an implementation of this option in a further version. With the menu settings (e.g. blog or featured) you can overwrite the global value from the settings.

Thank you for testing!

avatar Kubik-Rubik
Kubik-Rubik - comment - 20 Apr 2014

@ch2856 I added the option in these two menu layouts. So, please test it with the patchtester component (see answer from @zero-24) and write your result in the JoomlaCode entry so that the bugfix could be added in the next release.

avatar roland-d
roland-d - comment - 25 May 2014

I have tested the PR and there are 2 failures. See my comments on the JC tracker.

avatar Kubik-Rubik
Kubik-Rubik - comment - 27 May 2014

Tested successfully twice (see Joomlacode Tracker), please add to core.

avatar phproberto
phproberto - comment - 30 May 2014

This cannot be merged anymore. Can you please fix conflicts and refresh your pull request?

avatar Kubik-Rubik Kubik-Rubik - close - 31 May 2014
avatar Kubik-Rubik
Kubik-Rubik - comment - 31 May 2014

New pull request without code style changes: #3692

avatar Kubik-Rubik Kubik-Rubik - change - 31 May 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-05-31 17:03:10
avatar Kubik-Rubik Kubik-Rubik - close - 31 May 2014

Add a Comment

Login with GitHub to post a comment