[#34739] - [4.0] Fix menu rebuild message in menus
- Fixed in Code Base
- 10 Jul 2021
- Medium
- Build: 4.0-dev
- # 34739
- Diff
- chmst:menu-rebuild-message
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34739.
Thank you for testing. But the more I see the more I am convinced that the button "rebuild" on menus overview is wrong.
The menus themselves are not a nested sets and therefore must not be rebuilt.
This button rebuilds the structure of the menuItems. It belongs to menuItems. Wouldn't it be better to remove this button from the menus overview?
This button rebuilds the structure of the menuItems. It belongs to menuItems. Wouldn't it be better to remove this button from the menus overview?
I think the question is, in which case would we need / use this rebuild? I don't know.
Maybe then it will be easier to answer your question?
The rebuild button re-creates the paths of each menu item based on its alias, as well as the path of its parent item. Additionally, it fixes the lft and rgt fields. It is needed on menuItems overview. I am pretty sure that no one knows what it is for and that it does nothing with menus.
Thank you for testing. But the more I see the more I am convinced that the button "rebuild" on menus overview is wrong.
The menus themselves are not a nested sets and therefore must not be rebuilt.This button rebuilds the structure of the menuItems. It belongs to menuItems. Wouldn't it be better to remove this button from the menus overview?
@chmst RTC or not? It has 2 good tests. My personal opinion: As the button rebuilds the complete menu table, I would not remove it from the menus overview.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Decision to remove or not to remove the button can be done in a separate PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34739.
@richard67 RTC please . Thanks @Quy.
Will make an extra PR for removing the Button.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-10 13:24:14 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 7154bcd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34739.