[#34738] - [4.0] Use ExtensionHelper::getExtensionRecord to get finder plugin ID
- Fixed in Code Base
- 10 Jul 2021
- Medium
- Build: 4.0-dev
- # 34738
- Diff
- joomdonation:use_ExtensionHelper
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Instead of writing code to query #__extensions table to get finder plugin ID, this PR uses our extension ExtensionHelper::getExtensionRecord library method to get ID of the plugin as agreed by @wilsonge as #34645 (comment)
Testing Instructions
- Apply patch
- Go to Extensions -> Plugins, disable Content - Smart Search plugin.
- Access to Components -> Smart Search -> Index, there should be a warning message ask you to enable the plugin
- Click on the link (see the screenshot), make sure the right plugin is opened on modal popup so that you can enable it
Actual result BEFORE applying this Pull Request
Works, but more code than needed.
Expected result AFTER applying this Pull Request
Works and less code to maintain.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
on today 4.0-dev
- Access to Components -> Smart Search -> Index, there should be a warning message ask you to enable the plugin
there is not
yes i have disabled all finder plugins
ahh me silly not content smart search
anyway when clicking js error
Yes. Just realized that. It is because the modal is not loaded in empty state (happens before this PR, too).
If you index something, then empty state layout is not used and it should work well.
yeah , sure not depend from your pr, just discovered now me too
| Labels |
Added:
?
|
||
should'nt refresh the return page after enabling the content - smart search plugin ?
ie after clicking the link and enabling the content - smart search plugin
it report that the plugin is still disabled
@alikon Yes. @dgrammatiko Could you please give instructions for refresh ?
we have this update and refresh problem in lots of places
@joomdonation
You can refresh the page after closing the modal, using a script like that, inside the modal:
document.addEventListener('DOMContentLoaded', function() {
document.querySelector('#Modal_id').addEventListener('hide.bs.modal', function() {
window.parent.location.reload();
});
});
// Modal_id => The id of the modal window
But the "Save and Close" button is error prone, as in many cases the save will finish after the page is refreshed.
Hmm. Maybe we should do that in a separate PR, then as this is unrelated to the main change from this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34738.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34738.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34738.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-10 11:30:12 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thankyou!
I have tested this item✅ successfully on 1981f7f
Works like described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34738.