[#34722] - [4.0] Convert back "circle" classes to "unfeatured".
- Fixed in Code Base
- 6 Jul 2021
- Medium
- Build: 4.0-dev
- # 34722
- Diff
- bembelimen:4.0/34502
User tests: Successful: Unsuccessful:
Pull Request for Issue #34502 .
Summary of Changes
The "unfeatured" icons/buttons were changed to "circle" instead of changing the global declaration, so IDs were changed etc.
This PR changed them back and updates the global "icon-unfeatured" icon to circle.
Testing Instructions
Test 1:
Check unfeatured icon in com_content.
Test 2:
Activate workflow and check action dropdown
Actual result BEFORE applying this Pull Request
Unfeature icon is now "circle"
Dropdown for workflow broken
Expected result AFTER applying this Pull Request
"Unfeature icon" is back to "unfeatured"
Not visible with activated workflow
Additional
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact com_content Repository NPM Change Libraries |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34722.
Before this PR
After this PR
Thanks for testing.
As stated in the first post, it only fixes the dropdown, not the button in the list (with the wrong description). In your screenshot you see, when you enable the workflow, it still shows a "unfeature" entry (3rd from the bottom) which is wrong. This PR just remove it (you can see it in your 2nd screencast). Also this entry changed back the ID of this entry to "status-group-children-unfeatured" (instead of status-group-children-circle) when you inspect it.
as you can see in my gif I do not get the extra unfeatured item you highlight inyour screenshot
Hello Brian,
in the before PR screen you have it:
So that should not have been closed as this really is unrelated
I have tested this item
fixes dropdown menu only
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34722.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34722.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34722.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34722.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-06 20:06:37 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks!
I must be missing something here because I dont understand what you mean about changing IDs and there is no change in the behaviour of the featured/unfeatured button.
Before this PR without workflow you can click on the icon to toggle the featured status
Before this PR with workflow you can not click on the icon to toggle the featured status
Before this PR with workflow you can use the actions dropdown to toggle the featured status
Nothing has changed with this PR