? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
5 Jul 2021

Summary of Changes

Add !$this->isEmptyState when adding toolbar->delete()
It's similar to PR #34712

Testing Instructions

Trash all the tags and then empty trash for all tags

Actual result BEFORE applying this Pull Request

tags_before

Expected result AFTER applying this Pull Request

tags_after

Documentation Changes Required

No

avatar rjharishabh rjharishabh - open - 5 Jul 2021
avatar rjharishabh rjharishabh - change - 5 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2021
Category com_tags Administration
avatar Kostelano Kostelano - test_item - 5 Jul 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 5 Jul 2021

I have tested this item successfully on 2c90335


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34721.

avatar bembelimen bembelimen - test_item - 6 Jul 2021 - Tested successfully
avatar bembelimen
bembelimen - comment - 6 Jul 2021

I have tested this item successfully on 2c90335


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34721.

avatar bembelimen bembelimen - change - 6 Jul 2021
Status Pending Ready to Commit
avatar bembelimen
bembelimen - comment - 6 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34721.

avatar chmst chmst - close - 6 Jul 2021
avatar chmst chmst - merge - 6 Jul 2021
avatar chmst chmst - change - 6 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-06 06:00:23
Closed_By chmst
Labels Added: ? ?
avatar chmst
chmst - comment - 6 Jul 2021

Thanks!

avatar rjharishabh
rjharishabh - comment - 6 Jul 2021

Thanks

Add a Comment

Login with GitHub to post a comment