[#34672] - [4.0] Fix caption for the Ordering column and ascending/descending strings
- Fixed in Code Base
- 4 Jul 2021
- Medium
- Build: 4.0-dev
- # 34672
- Diff
- Quy:heading-caption
User tests: Successful: Unsuccessful:
Summary of Changes
In list view, the caption text is wrong for the Ordering column and ascending/descending are not translated.
Testing Instructions
Go to Global Configuration > System
Enable Debug Language.
In https://github.com/Quy/joomla-cms/blob/30c1d8ce688c9e84e6f996bb1877a9fdec23fc94/administrator/components/com_content/tmpl/articles/default.php#L110
Change <caption class="visually-hidden"> to <caption class="caption-top">.
Go to Content > Articles
In Sort Table By dropdown, select Ordering ascending/descending.
In Sort Table By dropdown, select Status ascending/descending.
Apply PR.
See captions for the above.
Actual result BEFORE applying this Pull Request
**Table of Articles**, **Sorted by:** **ID**,
**Table of Articles**, **Sorted by:** **ID**,
**Table of Articles**, **Sorted by:** **Status** - ascending,
**Table of Articles**, **Sorted by:** **Status** - descending,
Expected result AFTER applying this Pull Request
**Table of Articles**, **Sorted by:** ****Ordering** - ascending**,
**Table of Articles**, **Sorted by:** ****Ordering** - descending**,
**Table of Articles**, **Sorted by:** ****Status** - ascending**,
**Table of Articles**, **Sorted by:** ****Status** - descending**,
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Layout |
| Labels |
Added:
?
?
|
||
Added. Thanks!
changes in joomla.ini should be synced to the site and api versions
I don't understand. Added the new strings to both files.
there are 3 - site/admin/api
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34672.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34672.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34672.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-04 20:29:23 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
changes in joomla.ini should be synced to the site and api versions