[#34671] - [4.0] Crowdin comments
- Fixed in Code Base
- 12 Jul 2021
- Medium
- Build: 4.0-dev
- # 34671
- Diff
- brianteeman:crowdin
User tests: Successful: Unsuccessful:
This PR updates the comments in language strings to a format that crowdin understands as requested by @conconnl joomla/core-translations#1
Basically comments are moved to the end of the line in the *.ini
Note comments which are not for translators such as a comment used to indicate a group of strings have not been changed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Installation |
| Labels |
Added:
?
?
|
||
Thanks for checking @HLeithner - perfectly correct and updated
I think we looked into this already years ago and I know it didn't work at that time. I don't exactly remember the reasons however.
One was certainly that com_localise doesn't recognise those comments, but I think at that time Joomla couldn't handle them (language files broke I think). So please make sure everything related to language handling works when having the comments at the end (eg debugging languages)
I'm just doing the work that was requested - no need for the thumbs
So please make sure everything related to language handling works when having the comments at the end (eg debugging languages)
Already tested before submitting a pr
conflicts resolved
I have tested this item
The changes have no incidence in the outputs (like, for instance, creating an instance of the footer module)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34671.
Conflicts resolved again.
Please either merge this PR before the freeze that was requested by the language co-ordinators or close it. Not wasting my time any more
richard67
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-12 20:07:38 |
| Closed_By | ⇒ | HLeithner |
If tools around this PR breaks, we have to fix them or retire them if no longer used. Crowdin is our current translation platform and we should support it as good as we can.
Thanks @HLeithner
over to you now @conconnl
@HLeithner & @zero-24 Please look at it and merge.