Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34626] - [4.0] Comment : @see \JControllerLegacy

No Code Attached Yet J4 Issue
avatar chmst
chmst
24 Jun 2021

Steps to reproduce the issue

Inspect the code - there are lots of these comments, but a Class JControllerLegacy (or CotrollerLegacy) does no longer exist

avatar chmst chmst - open - 24 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Jun 2021
avatar chmst chmst - change - 24 Jun 2021
Labels Added: J4 Issue
avatar chmst chmst - labeled - 24 Jun 2021
avatar chmst
chmst - comment - 26 Jun 2021

There are alos lots of Comments * @return static A \JControllerLegacy .... which should be changed

avatar chmst
chmst - comment - 28 Jun 2021

@wilsonge what do you think here? Is removing comments and updating @return to

  • @return static A BasicController
    a good idea?
avatar wilsonge
wilsonge - comment - 10 Jul 2021

I've removed the @see references just now. I think

* @return static To allow chaining.

Might be good enough? I don't see any need to reference the class name to be honest - the static reference will deal with that - we just need to mention why we do it.

avatar brianteeman
brianteeman - comment - 6 Feb 2022

@chmst is this resolved for you now after @wilsonge changes?

avatar chmst chmst - change - 25 Aug 2022
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-08-25 20:42:52
Closed_By ⇒ chmst
Labels Added: No Code Attached Yet
Removed: ?
avatar chmst chmst - close - 25 Aug 2022

Add a Comment

Login with GitHub to post a comment