User tests: Successful: Unsuccessful:
Pull Request for Issue #34546 and #34545.
Adds the missing variables to cassiopeia to style the media manager properly on the front.
Please comment and test this one not before #34621 is merged!!!
Media manager has limited styling.
Media manager has proper styling, similar to back end.
Basically this pr adds the missing variables for front end templates. Can be used for proper documentation.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
It's fine as inline styles, but this needs to be documented that AFFECTS every front end template.
Also, a personal preference would be to change the prefix from template
to jdt
(joomla design token) or something similar. The template prefix is not really representative that these are Global design tokens. But maybe that's just me.
It's fine as inline styles, but this needs to be documented that AFFECTS every front end template.
Doing it in a stylesheet will mean that it can be updated in a new release without having to ask every template developer and site owner to update their own templates.
So wouldn't this be more obvious (and useful) as every template will need it
Pseudo code untested
// Enable assets
$wa->usePreset('template.cassiopeia.' . ($this->direction === 'rtl' ? 'rtl' : 'ltr'))
->useStyle('template.active.language')
->useStyle('template.user')
->useScript('template.user')
// global design classes
->useStyle('template.global');
Labels |
Added:
NPM Resource Changed
?
|
Category | Administration Templates (admin) NPM Change | ⇒ | Front End Templates (site) NPM Change |
I have tested this item
I have tested this item
thank you
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-23 22:30:58 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Nice work.
As these are not user editable in cassiopeia would it not be better to have them in a stylesheet instead of as an inline style. If this stylesheet was located in the /templates/system folder instead of the /templates/cassiopeia folder then it would be even better as it would be more obvious that a template developer needs to include it in their own template in order for media manager to work correctly in the front end