NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
24 Jun 2021

Pull Request for Issue #34546 and #34545.

Summary of Changes

Adds the missing variables to cassiopeia to style the media manager properly on the front.

Please comment and test this one not before #34621 is merged!!!

Testing Instructions

  • Set "Frontend images" to show in the articles options.
  • Edit an article on the front.
  • Click on "Images".
  • Click on "Select"

Actual result BEFORE applying this Pull Request

Media manager has limited styling.

Expected result AFTER applying this Pull Request

Media manager has proper styling, similar to back end.

Documentation Changes Required

Basically this pr adds the missing variables for front end templates. Can be used for proper documentation.

avatar laoneo laoneo - open - 24 Jun 2021
avatar laoneo laoneo - change - 24 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2021
Category Administration Templates (admin) NPM Change
avatar brianteeman
brianteeman - comment - 24 Jun 2021

Nice work.

As these are not user editable in cassiopeia would it not be better to have them in a stylesheet instead of as an inline style. If this stylesheet was located in the /templates/system folder instead of the /templates/cassiopeia folder then it would be even better as it would be more obvious that a template developer needs to include it in their own template in order for media manager to work correctly in the front end

avatar dgrammatiko
dgrammatiko - comment - 24 Jun 2021

It's fine as inline styles, but this needs to be documented that AFFECTS every front end template.
Also, a personal preference would be to change the prefix from template to jdt (joomla design token) or something similar. The template prefix is not really representative that these are Global design tokens. But maybe that's just me.

avatar brianteeman
brianteeman - comment - 24 Jun 2021

It's fine as inline styles, but this needs to be documented that AFFECTS every front end template.

Doing it in a stylesheet will mean that it can be updated in a new release without having to ask every template developer and site owner to update their own templates.

So wouldn't this be more obvious (and useful) as every template will need it

Pseudo code untested

// Enable assets
$wa->usePreset('template.cassiopeia.' . ($this->direction === 'rtl' ? 'rtl' : 'ltr'))
	->useStyle('template.active.language')
	->useStyle('template.user')
	->useScript('template.user')
	// global design classes
	->useStyle('template.global');
avatar laoneo laoneo - change - 29 Jun 2021
Labels Added: NPM Resource Changed ?
9a9d8c7 29 Jun 2021 avatar laoneo Copy
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2021
Category Administration Templates (admin) NPM Change Front End Templates (site) NPM Change
avatar laoneo
laoneo - comment - 19 Jul 2021

So this one can be tested now as #34621 got merged.

avatar chmst chmst - test_item - 22 Jul 2021 - Tested successfully
avatar chmst
chmst - comment - 22 Jul 2021

I have tested this item successfully on d2968b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34624.

avatar brianteeman brianteeman - test_item - 22 Jul 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Jul 2021

I have tested this item successfully on d2968b5

thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34624.

avatar alikon alikon - change - 22 Jul 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 22 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34624.

avatar wilsonge wilsonge - change - 23 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-23 22:30:58
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Jul 2021
avatar wilsonge wilsonge - merge - 23 Jul 2021
avatar wilsonge
wilsonge - comment - 23 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment