[#34617] - [4.0] Remove renderfield.php from com_contact
- Fixed in Code Base
- 2 Jul 2021
- Medium
- Build: 4.0-dev
- # 34617
- Diff
- drmenzelit:4.0-dev-confirmconsent
User tests: Successful: Unsuccessful:
Pull Request for Issue #34611 .
Summary of Changes
Removed the file components/com_contact/layouts/joomla/form/renderfield.php
Added some parameters for the modal window.
Testing Instructions
- Create a contact with contact form
- Activate the plugin "Content - Confirm Consent" and configure an article to be linked with.
- Go to the contact in frontend
- The field "Privacy Note" is a required field, you can't send the form without check in the box. But beside the label you will see the text "(optional)"
- Click on the link, a modal window will open
- Create a custom field of type radio for the contact form, set it as required, go to the form in frontend, you will see the text "(optional)" next to the label.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No "optional" text on required fields
All fields are rendered correctly
Modal window is bigger and will match the size of the modals of the other plugins when #34537 get merged.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact Plugins |
Looks really good. The only difference is, that the "(optional)" hint is no longer displayed if a field is not required.
If this can be deleted, then the language string COM_CONTACT_OPTIONAL="(optional)" can be removed too. As nowere else in Joomla a label "(optional)" is displayed, it seems ok to remove it also in the contact form.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
The file components/com_contact/layouts/joomla/form/renderfield.php
was not removed with the Prebuild Package either.
Probably need to rename this one?
For deleting files from the package, they must be added to a script if I understood this correctly. If you want to test already, you can remove (or rename) the file manually.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
Thanks for you Info. File removed. Result:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
You need to add the file to the list of files to be removed in administrator\components\com_admin\script.php
Thank you for the info. I will make the changes soon.
| Labels |
Added:
?
|
||
| Category | Front End com_contact Plugins | ⇒ | Administration com_admin Front End com_contact Language & Strings Plugins |
This is the wrong place. I know its hard to see in such a long list but they are grouped by release as wrong as ordered alphabetically
@brianteeman I guess you mean “as well as ordered alphabetically” and not “as wrong as ordered alphabetically”.
Autocorrect sucks
| Labels |
Added:
?
|
||
@drmenzelit I've allowed myself to move the file deletion in script.php to the right place for you.
I have tested this item
Test with Patchtester not possible.
Tested again with Prebuilt Package.
There was no need now, to remove the file components/com_contact/layouts/joomla/form/renderfield.php. manually.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
Hi,
I was following the testing instructions, using 4.0.0-rc3. but the problem you describe does not happen anymore.
Before applying the patch there was no "(optional)" close to required checkboxes.
So I did not test anything. Not sure if this patch is needed anymore.
Cheers,
Berta
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
@BertaOctech the problem appears on required radio fields and on the Privacy Note
I have tested this item
Thanks @drmenzelit
The privacy policy appeared correctly before applying the patch. I guess it was corrected elsewhere.
But I could see the problem for a required radio button.
"Optional" dissapeared when I applied the patch and renamed manually the file components/com_contact/layouts/joomla/form/renderfield.php.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34617.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-02 20:42:30 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
This is the original PR where the layout was created #8473