[#34616] - [4.0] Disabled options
- Closed
- 21 Jul 2021
- Medium
- Build: 4.0-dev
- # 34616
- Diff
- brianteeman:thu3
User tests: Successful: Unsuccessful:
Adds a background to disabled items in an option list
PR for #34496
Not convinced of the need for this myself someone else can decide
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34616.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34616.
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) NPM Change | ⇒ | Unit Tests Administration com_categories com_content com_finder com_menus com_tags com_users Language & Strings Templates (admin) NPM Change Repository JavaScript Front End com_contact Libraries Plugins Templates (site) |
| Labels |
Added:
?
?
|
||
| Category | Administration Templates (admin) NPM Change Unit Tests com_categories com_content com_finder com_menus com_tags com_users Language & Strings Repository JavaScript Front End com_contact Libraries Plugins Templates (site) | ⇒ | Administration Templates (admin) NPM Change |
Not convinced of the need for this myself someone else can decide
@brianteeman
A bit difficult. With the background, the disabled element looks emphasized even more. I think the background should not be changed. The text color could be lighter, so that sees that thist item is not selectable.
But for people with visual impairments this could be difficult. As always there is no perfect solution
Maybe remove the - Workflows - option which is redundant since the label is Worklows.
Similar fields have headlines and does not need extra background.
I'm confused... is - Workflow - an option that can be enabled? Or it is a label for the options below?
It is hardcoded. I assume it is acting as an <optgroup>.
I have to say I don't think this change looks good - to me it draws attention to the disabled option and borderline makes it look selected.
Is our problem on the original issue just on Safari that the default text colour looks too similar to the default disabled text color? Because if so maybe we just need to tweak the text colour rather than add a background
| Status | Ready to Commit | ⇒ | Needs Review |
Maybe remove the
- Workflows -option which is redundant since the label isWorklows.
That's not what this PR is about. The template needs to allow disabled options to be easily distinguished from options that are selectable. The workflow here is just an example of such a case where an option is disabled and yet you can't tell until you want to click on it.
@obuisard as @Quy and @chmst stated above, there is not an option and can't be enabled, the code is wrong
- Workflows -acts like a title of the group below, like-- From Component --in the screenshot from @chmst
I understand. The point here is not to fix the workflow selection but the template in general, which lacks styling for the disabled state.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-21 07:53:23 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
Removed: ? ? ? |
||
I have tested this item✅ successfully on 693a1cc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34616.