[#34591] - [4.0] Build tools: watch functionality revised
- Fixed in Code Base
- 22 Jun 2021
- Medium
- Build: 4.0-dev
- # 34591
- Diff
- dgrammatiko:—restore_watch-com_media—4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #34590.
Summary of Changes
- Restores the watch functionality
- Allows the
--watchto watch a specific folder - Implement the scss/css part
Testing Instructions
Com Media
- At you cmd run
npm run watch:com_media - then edit
administrator/components/com_media/resources/scripts/components/breadcrumb/breadcrumb.vue - Check both
media/com_media/js/media-manager.jsandmedia/com_media/js/media-manager.min.jsthat the mofified time was few seconds before and the content in both files is unmanggled JS
ES6, WebComponents, ES5
- run
npm run watch -- build/media_source/templates/administrator - Edit and save the file
build/media_source/templates/administrator/atum/js/template.es6.js - observe the modification time in the
media/templates/administrator/atum/js/template...files
SCSS, CSS
- run
npm run watch -- build/media_source/plg_system_webauthn - Edit and save the file
build/media_source/plg_system_webauthn/scss/button.scss - observe the modification time in the
media_source/plg_system_webauthn/scss/button...files
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
Yes, updated
There is one case that the watcher is not handling atm: if the source file gets deleted the compiled files are not removed as well.
@laoneo let me know if this is ok
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
It works, but there is no feedback that a file is compiled. Is this something can be done easily? If not I will mark the test as success.
Would also be nice if it gets printed because of which vue file the it was built. But fine for me now.
Would also be nice if it gets printed because of which vue file the it was built
This one needs a bit more research as the rollup docs don't mention anything helpful for getting the file that triggers the bundling. I guess there's a way to get it from chokidar which is the npm package used for the watch functionality from rollup...
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-22 13:37:15 |
| Closed_By | ⇒ | wilsonge |
Thanks both!
Let me know when I can test this?