? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Jun 2021

Hopefully this fixes #34523

Hopefully there are unit tests in existence which will verify that

For human testing
Create a multlingual site and check that the urls for the home pages are correct
Test with both suffix enabled and disabled

Before this PR the url would be example.com/fr.html
After this PR the url would be example.com/fr/

avatar brianteeman brianteeman - open - 17 Jun 2021
avatar brianteeman brianteeman - change - 17 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2021
Category Libraries
avatar brianteeman brianteeman - change - 17 Jun 2021
The description was changed
avatar brianteeman brianteeman - edited - 17 Jun 2021
avatar sandramay0905 sandramay0905 - test_item - 17 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 17 Jun 2021

I have tested this item successfully on d1cbbed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34538.

avatar richard67
richard67 - comment - 17 Jun 2021

Unfortunately this change also affects other pages than the home page.

On a copy of my homepage updated to 4.0 RC 2, I get https://test7.richard-fath.de/de/music/ for a categroy list with this PR applied, and not https://test7.richard-fath.de/de/music.html like it is on my J3 homepage or on the J4 copy without this PR.

avatar brianteeman
brianteeman - comment - 17 Jun 2021

That's why we should not be relying solely on human tests and should have automated testing

avatar richard67 richard67 - test_item - 17 Jun 2021 - Tested unsuccessfully
avatar richard67
richard67 - comment - 17 Jun 2021

I have tested this item ? unsuccessfully on d1cbbed

See my previous comment.

For other testers: It's not enough just to test the home pages which have the issue. If such changes are done with the router, it needs to test other pages, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34538.

avatar sandramay0905
sandramay0905 - comment - 17 Jun 2021

@richard67

For other testers: It's not enough just to test the home pages which have the issue. If such changes are done with the router, it needs to test other pages, too.

Test instructions by @brianteeman:

For human testing
Create a multlingual site and check that the urls for the home pages are correct
Test with both suffix enabled and disabled.

avatar richard67
richard67 - comment - 17 Jun 2021

@sandramay0905 Sorry, did not want to blame you or anyone. Only wanted to say sometimes it needs to test a bit more than instructions say.

avatar richard67
richard67 - comment - 17 Jun 2021

@sandramay0905 P.S. ... and thanks a lot for your testing activities in general. It really helps us a lot and is much appreciated.

avatar brianteeman
brianteeman - comment - 17 Jun 2021

without automated tests and documentation of how the urls are supposed to work its virtually impossible

avatar richard67
richard67 - comment - 18 Jun 2021

Alternative PR is #34558 . It will be ready for test soon.

Update: No, doesn't work (yet).

Update 2: Now it works. I only don't know if my PR is the right way to fix the issue.

avatar brianteeman brianteeman - change - 18 Jun 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-06-18 13:32:21
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 18 Jun 2021

Add a Comment

Login with GitHub to post a comment