User tests: Successful: Unsuccessful:
Hopefully this fixes #34523
Hopefully there are unit tests in existence which will verify that
For human testing
Create a multlingual site and check that the urls for the home pages are correct
Test with both suffix enabled and disabled
Before this PR the url would be example.com/fr.html
After this PR the url would be example.com/fr/
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Unfortunately this change also affects other pages than the home page.
On a copy of my homepage updated to 4.0 RC 2, I get https://test7.richard-fath.de/de/music/
for a categroy list with this PR applied, and not https://test7.richard-fath.de/de/music.html
like it is on my J3 homepage or on the J4 copy without this PR.
That's why we should not be relying solely on human tests and should have automated testing
I have tested this item
See my previous comment.
For other testers: It's not enough just to test the home pages which have the issue. If such changes are done with the router, it needs to test other pages, too.
For other testers: It's not enough just to test the home pages which have the issue. If such changes are done with the router, it needs to test other pages, too.
Test instructions by @brianteeman:
For human testing
Create a multlingual site and check that the urls for the home pages are correct
Test with both suffix enabled and disabled.
@sandramay0905 Sorry, did not want to blame you or anyone. Only wanted to say sometimes it needs to test a bit more than instructions say.
@sandramay0905 P.S. ... and thanks a lot for your testing activities in general. It really helps us a lot and is much appreciated.
without automated tests and documentation of how the urls are supposed to work its virtually impossible
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-18 13:32:21 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
|
I have tested this item✅ successfully on d1cbbed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34538.