[#34537] - [4.0] Modify modal window and remove orphan label in privacy consent and terms and conditions fields
- Fixed in Code Base
- 27 Jun 2021
- Medium
- Build: 4.0-dev
- # 34537
- Diff
- drmenzelit:4.0-dev-privacy
User tests: Successful: Unsuccessful:
Pull Request for Issue #34529, #33664 and #33664 (comment).
Summary of Changes
Modified the attributes bodyHeight and modalWidth in renderModal in the label layouts of privacy consent and terms and conditions. The values has to be int and not strings.
Furthermore removed the label element and related popover. The label was marked as orphaned element by WAVE as stated in the comment linked above.
Removed the description of the fields, it can't be hidden by configuration.
Testing Instructions
- Activate the plugins System - Privacy Consent and User - Terms and Conditions
- Configure both plugins
- Allow user registration
- Create a menu item for registration form
- Go to the registration form and click on the links to the Privacy Policy and Terms and Conditions, a modal window will open
- Inspect the code, if possible test with WAVE
Actual result BEFORE applying this Pull Request
See issue #34529
The modal window is very small
Inspect the code and you will see a label element surrounding the link
See comment #33664 (comment)
Expected result AFTER applying this Pull Request
No label element, only link if the plugin is correctly configured, only a span if the link is missing
The modal window is bigger now.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Thank you @sandramay0905 for the screenshots :-)
In a modal window with privacy, you need an indent from the block of information to the form with fields.
In a modal window with privacy, you need an indent from the block of information to the form with fields.
sorry, but I don't understand this, can you explain?
I have not tested, but paid attention to the screenshots (below is what I am talking about).
Sorry, maybe this is outside the scope of this PR.
Ah... that is not related to this PR, I think @sandramay0905 took a random menu item to test :-)
| Labels |
Added:
?
|
||
@brianteeman only partially, the semantic is hopefully better now, but I was not able to find a way to hide the field description
Question: Shouldnt the modal load without any page navigation
I think you can just delete the description. It doesnt add anything and its not displayed conditionally on the presence of a link.
Question: Shouldnt the modal load without any page navigation
There is no page navigation in the modal, or am I missing something?
I think you can just delete the description. It doesnt add anything and its not displayed conditionally on the presence of a link.
The description is a language string and loaded in the field (https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/privacyconsent/forms/privacyconsent.xml)
I know why and where the language string is used. I am saying that it can be deleted from both the ini and the xml.
Re page navigation I meant this
oh, I don't know if it possible to hide the navigation when a page is opened in a modal window...
I know why and where the language string is used. I am saying that it can be deleted from both the ini and the xml.
Thank you for confirming we can delete that.
| Category | Layout | ⇒ | Administration Language & Strings Layout Front End Plugins |
Do we need a similar message for the Terms of Service? If we DO NOT select material in the User - Profile (TOS parameters) plugin settings, then we just get a phrase without a link and without additional. block of information (like the one below in the screenshot). We must post Yes, it is not clear why and for what.
| Labels |
Added:
?
|
||
@Kostelano I'm afraid the Terms of Service is out of the scope of this PR. The profile plugin needs to be extended with a message field for TOS like in Privacy Consent or Terms & Conditions plugin. I'm not sure if my programming skills are good enough to do that. But that should be a separate PR.
I have tested this item
Ok, thanks. Then everything is fine for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34537.
I have tested this item
Also tested WAVE
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34537.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34537.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-27 22:43:27 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Modal
Privacy:
Terms and Conditions:
Label element:
span with pull request:
