[#34520] - [4.0] Fix drag and drop ordering
- Fixed in Code Base
- 27 Jun 2021
- Medium
- Build: 4.0-dev
- # 34520
- Diff
- joomdonation:fix_drag_and_drop_ordering
User tests: Successful: Unsuccessful:
Pull Request for Issue #34498.
Summary of Changes
My attempt to fix #34498. Currently, we only submit data between drag and drop element to server for updating ordering. Now, I modified it so that data from all rows (within same group if there is group) will be submitted in ajax request (basically, same with J3).
Testing Instructions
- See https://github.com/joomla/joomla-cms/issues/34498to understand the issue.
- Download update package for this PR at https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/34520/downloads/45195/Joomla_4.0.0-rc2-dev+pr.34520-Development-Update_Package.zip , go to System -> Update -> Joomla, upload this package and run the update.
- Try to re-order menu items, (both parent and children categories), articles, modules and make sure ordering of these items are saved when you re-fresh the page.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
As my site is online, I wanted to do so by using the update link. But I got an error message.
@Magnytu2 There could be several reasons causing the error like the path to tmp folder is not correct, out of diskspace or permission error...
Could you please try to download the update package for this PR, then go to System -> Update -> Joomla, upload and update the package manually?
@richard67 No it does not want to do it.
@joomdonation The package is too big for me to do it this way. I will do it by Filezilla
Awesome it works. A big thank-you. As I am working on many screenshots, is it possible to rename the version name of Joomla?
@Magnytu2 You can modify this line of code https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/modules/mod_version/tmpl/default.php#L19
Change it to something like:
<span aria-hidden="true"><?php echo 'Joomla 4'; ?></span>Replace Joomla 4 with the text you want to display.
Could you please mark your test result in issue tracker?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34520.
@Magnytu2 You can modify this line of code https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/modules/mod_version/tmpl/default.php#L19
Change it to something like:
<span aria-hidden="true"><?php echo 'Joomla 4'; ?></span>Replace Joomla 4 with the text you want to display.
It does not work. Do you have another suggestion please?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34520.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34520.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-27 10:21:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
Documentation Required
|
||
Thanks!
@Magnytu2 @brianteeman Could you please check to see if this PR solves the issue you are having?