[#34516] - [4.0] Fix com_joomlaupdate js error
- Fixed in Code Base
- 15 Jun 2021
- Medium
- Build: 4.0-dev
- # 34516
- Diff
- joomdonation:fix_joomlaupdate_js_error
User tests: Successful: Unsuccessful:
Pull Request for Issue #34510.
Summary of Changes
This PR fixes few js error for com_joomlaupdate. See #34510 for more details. It also fixes an error in the console when the page is loaded (You need to install a third party extension like JCE to see this error - or code review)
Testing Instructions
- See #34510 to understand the issue
- Download update package for this PR, go to System -> Update -> Joomla to install the update package for this PR (or apply patch, and run npm command, sorry I don't remember the command to run)
- Check and confirm the issue is gone.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
@richard67 I don't see the issue myself for some reasons. Maybe it's because I have some third party extension installed (JCE, and my own extensions). But I saw that error before and the modification in that line of code fixes that. The # character is needed for old code (jQuery) but not needed on document.getElementById
@richard67 I don't see the issue myself for some reasons. Maybe it's because I have some third party extension installed (JCE, and my own extensions). But I saw that error before and the modification in that line of code fixes that. The # character is needed for old code (jQuery) but not needed on document.getElementById
@joomdonation No need to explain me the "#" change, I understand that already.
No need to explain me the "#" change, I understand that already.
Sorry, I just tried to explain the reason for the change on that line of code.
@joomdonation Yes but unfortunately it still doesn't work. Seems there is something more wrong with that element id.
I can't see any html element having an id "plg_226", which is the one for which the document.getElementById call fails. 226 is the id of the JCE extension in my installation.
Somehow, it relates to logic of com_joomlaupdate which I don't understand yet. The element is only available if the layout administrator/components/com_joomlaupdate/tmpl/joomlaupdate/default_update.php is loaded , but in this case, it is not loaded for some reasons (maybe it is because no update found for that extension, will need to look more at com_joomlaupdate to understand)
@joomdonation One solution could be that you revert that one change which is not related to the issue and which does not work for me, so the other change can be tested before RC 2 is made tonight, and for the remaining js error make a new issue.
| Labels |
Added:
NPM Resource Changed
?
|
||
@richard67 OK. We will handle that change on a separate PR.
I have tested this item
Fixes #34510 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34516.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-15 07:44:10 |
| Closed_By | ⇒ | wilsonge |
Thanks!
@joomdonation It fixes the error in my issue, but regarding the console error there is still
Uncaught TypeError: document.getElementById(...) is nullhere: https://github.com/joomla/joomla-cms/pull/34516/files#diff-550b2e9757e1fef80e3714191e4f70f3dd9bd7441ff3e7679698de031551e346R420