? ? good first issue Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Jun 2021

follow up ##34447 (comment) .

Summary of Changes

from v1/banners/contenthistory/:id to v1/banners/:id/contenthistory
from v1/content/articles/contenthistory/:id to v1/content/articles/:id/contenthistory
from v1/contacts/contenthistory/:id to v1/contacts/:id/contenthistory

Testing Instructions

test all contehistory endpoints

Documentation Changes Required

yes

avatar alikon alikon - open - 11 Jun 2021
avatar alikon alikon - change - 11 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2021
Category Front End Plugins
avatar pjdevries
pjdevries - comment - 11 Jun 2021

Since we are in the process of reviewing endpoints, I have a question and accompanying suggestion. Why is it v1/content/articles? Doesn't v1/articles make more sense?

avatar alikon
alikon - comment - 11 Jun 2021

Why is it v1/content/articles?

i dunno
i wasn't in that GSOC team , maybe @wilsonge can shed some light

Doesn't v1/articles make more sense?

make sense for me, anyway , matter for another pr possibly

avatar alikon
alikon - comment - 11 Jun 2021
avatar wilsonge wilsonge - change - 13 Jun 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-13 22:45:16
Closed_By wilsonge
Labels Added: ? ? good first issue
avatar wilsonge wilsonge - close - 13 Jun 2021
avatar wilsonge wilsonge - merge - 13 Jun 2021
avatar wilsonge
wilsonge - comment - 13 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment