[#34487] - [4.0] Fix sorted by: table caption
- Fixed in Code Base
- 11 Jun 2021
- Medium
- Build: 4.0-dev
- # 34487
- Diff
- rjharishabh:searchtools
User tests: Successful: Unsuccessful:
Pull Request for Issue #34476.
Summary of Changes
correct ternary operator in $data->direction
Testing Instructions
Visit the articles page in the backend
Sort the table, for example - by Status ascending
Just look at the table caption in the developer tools or just remove class="visually-hidden" from the code
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
This changes the direction of the arrow which is a toggle. With this PR, re-ordering is no longer possible.
I have tested this item
breaks column header sort
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.
I have not tested this item.
breaks column header sort
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.
I have tested this item
breaks column header sort
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Layout |
@brianteeman @chmst @sandramay0905 Please test once more
I have tested this item
Ordering works and is synchron with visually hidden text.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-11 17:54:02 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
PBF
|
||
Thanks!
Thanks everyone
I have tested this item✅ successfully on f6f6428
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487.