Feeling Lucky
NPM Resource Changed
?
?
?
[#34480] - [4.0] Sanitize modals
- Fixed in Code Base
- 12 Jun 2021
- Medium
- Build: 4.0-dev
- # 34480
- Diff
- dgrammatiko:—sanitize-modals—4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This is also a RELEASE BLOCKER
Summary of Changes
- sanitize the iframe tag passed as a data attribute
Testing Instructions
Apply the patch or download the installable package from the Github PR
Try to edit an article, select an image, select a user
Try to edit a menu item and create/edit an article
Modals should work fine
Actual result BEFORE applying this Pull Request
The initialization of a modal could be compromised to run non verified code
Expected result AFTER applying this Pull Request
The iframe tag can not be compromised
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
?
|
||
jwaisner
- comment
- 10 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34480.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 10 Jun 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34480.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-12 12:45:15 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
Removed: ? |
||
richard67
- comment
- 12 Jun 2021
Thanks!
I have tested this item✅ successfully on ea7b59a
Test was:
Single article, create article, save menu-item, view in front end. Reopen menu-item, edit article, save and view in frontend again.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34480.