Feeling Lucky
NPM Resource Changed
?
[#34478] - [4.0] Convert inline to file and remove jQuery
- Fixed in Code Base
- 17 Jun 2021
- Medium
- Build: 4.0-dev
- # 34478
- Diff
- dgrammatiko:—remove-jquery-4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- moves inline script to a file
- removes the jQuery dependency
- Replaces
alert()withconfirm() - Changes the logic: on confirm yes apply the same filter to all the child user groups
Testing Instructions
Goto administrator/index.php?option=com_config and select the tab Text Filters
Apply No Filtering to Author
If you respond with yes to the popup then all the descending groups will also have a No Filtering value
if not then the rule will apply to the Author
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@brianteeman could you take a look at the string COM_CONFIG_TEXT_FILTERS_NOTE
Another observation here: the PHP should correctly calculate the selected filter depending on the parent if the selected value is no filtering (not what happens right now, which is completely confusing)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Repository NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
?
|
||
richard67
- 
wilsonge
- comment
- 14 Jun 2021
Sorry dude can you sort conflicts here?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-17 09:28:55 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 17 Jun 2021
Thanks!
I have tested this item✅ successfully on 3177492
For Test: Using Firefox "OK" is "Yes", "Cancel" is "No":
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34478.