[#34456] - [4.0] com_joomlaupdate typos
- Fixed in Code Base
- 9 Jun 2021
- Medium
- Build: 4.0-dev
- # 34456
- Diff
- brianteeman:com_joomlaupdate
User tests: Successful: Unsuccessful:
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
| Category | Administration com_joomlaupdate | ⇒ | Administration com_joomlaupdate JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
You can check the generated file
media\com_joomlaupdate\js\default.js
You can check the generated file
media\com_joomlaupdate\js\default.js
I had also checked the above before. Checked now again:
Line 367:
// eslint-disable-next-line max-len
Line 378:
html = Joomla.JText._('COM_JOOMLAUPDATE_VIEW_DEFAULT_EXTENSION_NO_COMPATIBILITY_INFORMATION');
Line 397:
document.getElementById('compatibilitytype0').style.display = 'block'; // Process the nonCoreCriticalPlugin list
Line 398: blank
The line numbers will be different just look at the changed lines and find and compare
https://github.com/joomla/joomla-cms/pull/34456/files
I have tested this item
code changes look good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34456.
I have tested this item
Look good!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34456.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34456.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-09 11:08:17 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
thanks
Prebuild Package used. In principle sucessful, except that I don't know how to check the file:
build/media_source/com_joomlaupdate/js/default.es6.js