? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
7 Jun 2021

Summary of Changes

For consistency, replace double quote with singe quote.

Testing Instructions

Code review.

avatar Quy Quy - open - 7 Jun 2021
avatar Quy Quy - change - 7 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2021
Category Administration com_associations com_redirect Front End com_content Layout Libraries Plugins
avatar alikon
alikon - comment - 7 Jun 2021

what it is supposed to be standard? if there is 1

avatar Bakual
Bakual - comment - 7 Jun 2021

what it is supposed to be standard? if there is 1

There is no official standard. ?

avatar HLeithner
HLeithner - comment - 7 Jun 2021

Always use single quote except you want to use fast rope which is faster but personally I don't variables within a text block, it's less readable without a syntax highlighter.

avatar alikon alikon - test_item - 8 Jun 2021 - Tested successfully
avatar alikon
alikon - comment - 8 Jun 2021

I have tested this item successfully on e299c59

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34452.

avatar joomdonation joomdonation - test_item - 9 Jun 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 9 Jun 2021

I have tested this item successfully on e299c59


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34452.

avatar joomdonation joomdonation - change - 9 Jun 2021
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 9 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34452.

avatar drmenzelit drmenzelit - change - 9 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-09 07:17:02
Closed_By drmenzelit
Labels Added: ? ?
avatar drmenzelit drmenzelit - close - 9 Jun 2021
avatar drmenzelit drmenzelit - merge - 9 Jun 2021
avatar drmenzelit
drmenzelit - comment - 9 Jun 2021

Thanks

Add a Comment

Login with GitHub to post a comment