? ?
avatar carcam
carcam
4 Jun 2021

It seems that language switcher dropdown does not have a different style when receiving the focus. This fails with https://www.w3.org/WAI/WCAG22/Understanding/focus-appearance-minimum .

Steps to reproduce the issue

  1. Add Language Switcher to the site
  2. Go to the homepage of the site
  3. Use your keyboard (Tab key) to reach the dropdown

Expected result

When reaching the dropdown it should show a focus state like in the following screenshot:

Captura de pantalla 2021-06-04 a las 16 54 22

Actual result

The dropdown shows no change when having the focus as per the screenshot:

Captura de pantalla 2021-06-04 a las 16 53 38

System information (as much as possible)

  • Joomla 4 from GH repo after npm ci and composer update.

Additional comments

This seems to be a general issue when using BS5 dropdown so probably we should consider adding a generic fix like:

a.btn.dropdown-toggle:focus { border: 1px solid #8894AA; }

@joomla/joomla-accessibility-team-jat

avatar carcam carcam - open - 4 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Jun 2021
avatar brianteeman
brianteeman - comment - 4 Jun 2021

confirm the issue but not the fix - the problem is the outline that is being set to 0 here

  .btn-check:focus + &,
  &:focus {
    outline: 0;
    box-shadow: $btn-focus-box-shadow;
  }

avatar brianteeman
brianteeman - comment - 4 Jun 2021
avatar chmst chmst - labeled - 4 Jun 2021
avatar chmst chmst - change - 4 Jun 2021
Labels Added: ?
avatar drmenzelit
drmenzelit - comment - 4 Jun 2021

@carcam can you please test #33929 and let me know what is missing?

avatar carcam
carcam - comment - 5 Jun 2021

@carcam can you please test #33929 and let me know what is missing?

Great job there!! That fixes this issue among others we had with this switcher ;)

confirm the issue but not the fix - the problem is the outline that is being set to 0 here

  .btn-check:focus + &,
  &:focus {
    outline: 0;
    box-shadow: $btn-focus-box-shadow;
  }

I agree, the outline is much better.

Thanks @brianteeman and @drmenzelit !!

avatar richard67 richard67 - change - 5 Jun 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-06-05 09:10:39
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67 richard67 - close - 5 Jun 2021
avatar richard67
richard67 - comment - 5 Jun 2021

Closing as having a pull request. Please test #33929 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment