? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Jun 2021

Nothing major but it bugs me that the template styles are "atum - Default" and "cassiopeia - Default" with the template name being all lower case.

This PR will change that for new installations
@richard67 For upgrades from J3 do I editadministrator\components\com_admin\sql\updates\mysql\4.0.0-2018-03-05.sql` or create a new sql file

avatar brianteeman brianteeman - open - 4 Jun 2021
avatar brianteeman brianteeman - change - 4 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2021
Category SQL Installation Postgresql
avatar richard67
richard67 - comment - 4 Jun 2021

@richard67 For upgrades from J3 do I editadministrator\components\com_admin\sql\updates\mysql\4.0.0-2018-03-05.sql` or create a new sql file

@brianteeman For update from J3 it would be enough to edit the old file. But what about updates from J4 Beta versions or RC? For these it will need a new script. It's then a matter of taste if the old script is changed, too, in addition to the new one, but I suggest to do that. But that depends a bit on if in later update SQL scripts that old name is used somehow or not. So if you wanna play safe, don't change the old script and only make a new one. I will try to find time on weekend if necessary and have a look on it.

avatar brianteeman brianteeman - change - 4 Jun 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2021
Category SQL Installation Postgresql SQL Administration com_admin Postgresql Installation
27b6705 4 Jun 2021 avatar brianteeman typo
avatar brianteeman
brianteeman - comment - 4 Jun 2021

thanks @richard67 hopefully this is correct

avatar richard67
richard67 - comment - 4 Jun 2021

@brianteeman Looks ok on review.

avatar Quy Quy - test_item - 5 Jun 2021 - Tested successfully
avatar Quy
Quy - comment - 5 Jun 2021

I have tested this item successfully on 27b6705


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34399.

avatar sandramay0905 sandramay0905 - test_item - 6 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 6 Jun 2021

I have tested this item successfully on 27b6705


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34399.

avatar jwaisner jwaisner - change - 6 Jun 2021
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 6 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34399.

avatar richard67 richard67 - change - 6 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-06 13:15:50
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 6 Jun 2021
avatar richard67 richard67 - merge - 6 Jun 2021
avatar richard67
richard67 - comment - 6 Jun 2021

Thanks!

avatar brianteeman
brianteeman - comment - 6 Jun 2021

thanks

Add a Comment

Login with GitHub to post a comment