[#34375] - [4.0] Fix drag and drop re-ordering for grouped items
- Fixed in Code Base
- 6 Jun 2021
- Medium
- Build: 4.0-dev
- # 34375
- Diff
- joomdonation:fix_drag_and_drop
User tests: Successful: Unsuccessful:
Pull Request for Issue #34369.
Summary of Changes
This PR fixes the issue #34369
Testing Instructions
- See #34369 to understand the issue.
- Install Joomla 4 nightly build. Install Blog sample data so that you have data ready for testing
- Create additional categories if needed so that you will have parent-children categories on your site.
- Download update package for this PR at https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/34375/downloads/44812/Joomla_4.0.0-rc2-dev+pr.34375-Development-Update_Package.zip , go to System -> Update -> Joomla, upload this package and run the update.
- Try to re-order categories (both parent and children categories), articles, modules and make sure ordering of these items are saved when you re-fresh the page.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-03 12:33:17 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-06-03 12:33:17 | ⇒ | |
| Closed_By | joomdonation | ⇒ |
| Status | New | ⇒ | Pending |
OK. I tested it myself and it works. I updated testing instructions, please test. Thanks.
I have tested this item successfully, sorry I don't know really know how to test via composer
I have tested this item
The ordering of parent- and children-categories, articles and modules is saved after refresh of the page.
Question: Drag'n'Drop a parent-category show children-categories only after page-refresh (please see video below). A different Issue?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34375.
@sandramay0905 Yes. It is different issue. It depends on the script which we are using to handle drag and drop. I asked @dgrammatiko and @Fedik about it #34369 (comment) .
RTC. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34375.
@joomdonation do i have to open a issue for handle drag and drop or is your comment enough?
@sandramay0905 Yes. Please open a new issue for that. Thanks !
| Status | Pending | ⇒ | Ready to Commit |
RTC again. It was lost when a new comment added.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34375.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-06 08:38:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks! Nice job!
No, sorry. Not this simple. We should only calculate and update ordering of items in the same group/level only. This won't work. I'm closing this PR and will re-open it if I can come up with a solution.