User tests: Successful: Unsuccessful:
The Json string should be corrected as "core_urls":"url" but not "core_urls":"urls"
because the field name in the old weblink table is different than all the others.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-13 17:57:12 |
Labels |
Added:
?
?
|
Status | Closed | ⇒ | New |
Ok Sure i will have a look.
@Bakual The three files modified in the com_admin directory has changed after the PR. But it hasn't been the same case with the files in the installation folder. The PR hasn't changed the 3 files in the installation folder and in my PR it only addresses one sql file have to update others as well.
Thanks! Thinking about it, we may need a update SQL files as well to fix the content types for updating users.
That would need a file in the com_admin folder like the ones changed in the original folder.
The name of the file would be 3.3.0-2014-04-14.sql
(or whatever date you create them).
Can you do that as well?
And we likely also need a tracker item on JoomlaCode.
I've pushed some unnecessary commits while trying to update the PR will create a new PR sorry for the inconvenience caused.
#3446 This PR is for the installation folder modifications.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33610
Closed in favour of the new PRs
Status | New | ⇒ | Closed |
Closed_Date | 2014-04-13 17:57:12 | ⇒ | 2014-08-08 14:40:11 |
That's indeed true, and was fixed 10 months ago with PR #1280.
It was reintroduced again with the content versioning
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30944
Commit: f9e8702
So I agree with your PR here, but can you check the other files which were changed with the first PR and see if the same error has been reintroduced there as well?