?

User tests: Successful: Unsuccessful:

avatar infazse
infazse
13 Apr 2014

The Json string should be corrected as "core_urls":"url" but not "core_urls":"urls"

because the field name in the old weblink table is different than all the others.

avatar infazse infazse - open - 13 Apr 2014
avatar infazse infazse - change - 13 Apr 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-04-13 17:57:12
Labels Added: ? ?
avatar infazse infazse - close - 13 Apr 2014
avatar infazse infazse - close - 13 Apr 2014
avatar infazse infazse - head_ref_deleted - 13 Apr 2014
avatar infazse infazse - reopen - 13 Apr 2014
avatar infazse infazse - change - 13 Apr 2014
Status Closed New
avatar infazse infazse - reopen - 13 Apr 2014
avatar Bakual
Bakual - comment - 13 Apr 2014

That's indeed true, and was fixed 10 months ago with PR #1280.
It was reintroduced again with the content versioning
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30944
Commit: f9e8702

So I agree with your PR here, but can you check the other files which were changed with the first PR and see if the same error has been reintroduced there as well?

avatar infazse
infazse - comment - 14 Apr 2014

Ok Sure i will have a look.

avatar infazse
infazse - comment - 14 Apr 2014

@Bakual The three files modified in the com_admin directory has changed after the PR. But it hasn't been the same case with the files in the installation folder. The PR hasn't changed the 3 files in the installation folder and in my PR it only addresses one sql file have to update others as well.

avatar infazse
infazse - comment - 14 Apr 2014

@Bakual - Updated the PR with additional changes.

avatar Bakual
Bakual - comment - 14 Apr 2014

Thanks! Thinking about it, we may need a update SQL files as well to fix the content types for updating users.
That would need a file in the com_admin folder like the ones changed in the original folder.
The name of the file would be 3.3.0-2014-04-14.sql (or whatever date you create them).

Can you do that as well?
And we likely also need a tracker item on JoomlaCode.

avatar infazse
infazse - comment - 14 Apr 2014

@Bakual Ok will look in to it :) What should be the content of the file?! I should create 3 files respectively for sql, postgresql and sqlazure in the com_admin folder and the file should consist the change i have included right?

avatar Bakual
Bakual - comment - 14 Apr 2014

Probably similar to what was done in the PR #1280. You need an SQL statement which will update the content type for com_weblinks with the correct content.
And yes, for each database respectively in their folder.

avatar infazse
infazse - comment - 14 Apr 2014

I've pushed some unnecessary commits while trying to update the PR will create a new PR sorry for the inconvenience caused.

avatar infazse
infazse - comment - 14 Apr 2014

#3443 new PR with updates!!!

avatar infazse
infazse - comment - 14 Apr 2014
avatar brianteeman
brianteeman - comment - 8 Aug 2014

Closed in favour of the new PRs

avatar brianteeman brianteeman - change - 8 Aug 2014
Status New Closed
Closed_Date 2014-04-13 17:57:12 2014-08-08 14:40:11
avatar brianteeman brianteeman - close - 8 Aug 2014

Add a Comment

Login with GitHub to post a comment