[#3436] - [#33607] Replace FOFLess use with JLess wrapping lessc library
- Closed
- 6 Jun 2014
- Medium
- Build: 3.3-dev
- # 3436
- Diff
- mbabker:JLess
- Foreign ID 33607
- Error The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
As part of decoupling the core CMS from FOF, this PR breaks the dependency on FOF's LESS classes. FOF had implemented the lessc library by inlining its code into classes for proper code styling. Replacing it is JLess which extends the base lessc class. The full lessc library is included as a third party library here to enable easier updating of the library when able.
All of the FOF classes are flagged @deprecated and modified to extend their lessc counterparts except for FOFLess and FOFLessFormatterJoomla, which now extend their JLess counterparts.
To test this, one should verify that the Template Manager still correctly compiles LESS files or the build/generatecss.php CLI script still functions. Also, if there are third parties using the FOFLess classes, those should still function correctly.
JoomlaCode: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33607&start=0
| Title |
|
||||||
Our use of the LESS library is within the scope of PHP code. It'd be a different argument if it were being called in another scope.
Our use of the less library is in the compiler - that isn't distributed with the CMS. My point is that the lessc library doesn't have to be distributed with the CMS either. We can shove it in the build folder if that's all we're gonna use it for. Then FOF is only in FOF and we have time to think about how we want people to play with less in the CMS.
The compiler is used in the Template Manager and as such required to ship with the CMS.
Ahh crud. fair enough then :)
On 14 April 2014 01:10, Michael Babker notifications@github.com wrote:
Further history - https://github.com/joomla/joomla-cms/pull/2311/files
Reply to this email directly or view it on GitHub#3436 (comment)
.
I'd suggest getting this PR through first so that we separate back out the lessc library from a class used in the core API then the Composer install is rather simple.
Tested both in template manager and using my own extension. Works fine and PR looks also good from code review.
Needs to go into next minor (currently 3.4) since we deprecate methods.
One more test please.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-06 11:57:22 |
I'm not convinced we should be bundling lessc library in core. I know FOF did - but doesn't mean it's the right thing. If we're going to bundle a library with joomla I personally would much rather bundle lessjs