Feeling Lucky
?
[#34357] - Update Sites filtering breaks when changing the "Select Download Key"
- Fixed in Code Base
- 2 Jun 2021
- Medium
- Build: 4.0-dev
- # 34357
- Diff
- nikosdion:fix/34353-updatesites-dlkey-filter
User tests: Successful: Unsuccessful:
Pull Request for Issue #34353 .
Summary of Changes
Fixed the UpdatesitesModel in com_installer to reset the view when you deselect the Select Download Key filter.
I also added the missing getStoreId method to properly support sites with caching enabled.
Testing Instructions
- Go to System, Update Sites
- Click the “- Select Download Key -” dropdown and select “Download Key Supported”.
- After the page reloads click the same dropdown and select “- Select Download Key -”.
Actual result BEFORE applying this Pull Request
You see no entries.
Expected result AFTER applying this Pull Request
You see all entries, as expected.
Please note that if you are using caching on your site you need to go to System, Clear Cache and click on Delete All before retrying the testing instructions after applying the Pull Request.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-02 08:09:03 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
nikosdion
- comment
- 2 Jun 2021
Cheers, mate!
PhilETaylor
- comment
- 2 Jun 2021
@nikosdion welcome back /me runs for cover...
Happy to merge this one on review. Thankyou!