[#34353] - Update Sites filtering breaks when changing the "Select Download Key" dropdown.
- Closed
- 2 Jun 2021
- Medium
- Build: staging
- # 34353
Steps to reproduce the issue
- Go to System, Update Sites
- Click the “- Select Download Key -” dropdown and select “Download Key Support”.
- After the page reloads click the same dropdown and select “- Select Download Key -”.
Expected result
All Update Sites listed.
Actual result
No Update Sites listed.
System information (as much as possible)
Confirmed on PHP 7.4 and 8.0. The environment seems to be irrelevant, though.
Additional comments
This is a bug in code I had contributed in 2019, namely
The switch statement above should be setting $supportedIDs to null and the noted line should have a check for a non-null result.
I will submit a PR shortly.
joomla-cms-bot
- | Labels |
Added:
?
|
||
We can close here while we have the PR right?
wilsonge
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-02 08:07:51 |
| Closed_By | ⇒ | wilsonge |
BTW, you don't have to close my issues when I submit a PR. I always include the text "closes blah-blah" as the first thing in my PR description so that the issue is auto-closed by GitHub when you merge the PR. IMHO it makes it easier for people to see if an issue is known — most people will search the issues but almost nobody looks into open PRs.
BTW, you don't have to close my issues when I submit a PR. I always include the text "closes blah-blah" as the first thing in my PR description so that the issue is auto-closed by GitHub when you merge the PR.
The Joomla Way
This was also a duplicate of #34132 (comment) which you missed before opening this :)
Yeah, I'd missed your issue. It didn't come up when I searched. I believe you called it Download ID, Joomla calls it Download Key and I searched for the latter. Nothing immediately popped up so I filed an issue :)
ah :) haha
If Microsoft is hearing, we'd like some AI in the issues search so it can figure out subtle differences in terminology to avoid awkward situations like this...
Confirmed. Thanks.